Comments (7)
We indeed need to update Funfix's IO with the latest developments, which includes bracket
.
Your proposal might work for now, but note that:
acquire
has to be uncancelablerelease
has to be uncancelable- I don't remember if
doOnCancel
does the right thing, but we need to ensure that eitherdoOnCancel
ordoOnFinish
execute and not both
We would also need a bracketCase
that discriminates between the exit cases, like we pushed in Cats-Effect.
I'm caught up with work on Monix and Cats-Effect at the moment, unfortunately. Plus work and life, I did not have any time left for Funfix.
Once Cats-Effect 1.0 and Monix 3.0 will be finally out, I hope to have some time for giving Funfix some needed updates.
Until then PRs are welcome in case you'd like to give it a try.
from funfix.
About 1 and 2, is there a way to enforce this?
About 3, I've made the tests and it works.
I Maybe do a PR, but I'm not versed into Flow..
from funfix.
I've seen cancelable
IO are IOAsync which have the cancellation logic in their Context.
On may use a constraint using the '_tag' value to enforce statically correct usage of the API but I find that sloppy.
SO I guess, I just need to make them become uncancellable in the implementation of bracket.
from funfix.
Don't we have an uncancelable
operation already?
from funfix.
@alexandru Not found one actually..
from funfix.
Here's the issue: #138
from funfix.
from funfix.
Related Issues (20)
- TNone.value typed as undefined breaks the compilation HOT 1
- Add Semigroup HOT 1
- Help with compose and point free functions. HOT 1
- [Feature Request] Add a datastructure for Tuple HOT 5
- [v.6.2.2] export statement in es5.js
- Why do you have to create a success option manually with Option<T>.flatmap? HOT 1
- Right way to handle a Future that returns an either?
- Documentation is dead HOT 2
- Add `uncancelable` for IO HOT 4
- Infinite loop in lerna project setup
- An in-range update of funland-laws is breaking the build π¨ HOT 1
- Option.of is non-parametric HOT 4
- An in-range update of rimraf is breaking the build π¨ HOT 1
- Is Validated/Validation out of scope for funfix-core HOT 1
- An in-range update of tsc-watch is breaking the build π¨ HOT 1
- An in-range update of rollup-plugin-commonjs is breaking the build π¨ HOT 1
- Use 7.0.1 funfix version in Angular based on Webpack HOT 2
- I think there's a bug inside `scheduleAtFixedRate` HOT 1
- Project status and future
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from funfix.