Comments (8)
Neat. The only other weird oddity for the Go package is that everything is under pkg
. Usually, if a repo is just a library and not an application, the resources are under root. A good(ish) example can be found here, although I wouldn't say that it is important enough to break existing changes.
Also while I was glancing about, I noticed that the README example has invalid go syntax, so I fixed that for you FusionAuth/go-client#10
from fusionauth-client-builder.
@GrimTheReaper this is just our pattern thus far.
@matthew-altman Any potential issues you see with a change such as this?
from fusionauth-client-builder.
@robotdan It's a matter of renaming every client repo. Not hard, but there would be a lot of downstream repo changes as well...maven, npm, etc
from fusionauth-client-builder.
@matthew-altman what about just for Go, is the package stuttering an issue with Go?
from fusionauth-client-builder.
@robotdan No problem changing it for Go. It's not an issue, per se, but isn't idiomatic. I'll see what I can do.
from fusionauth-client-builder.
This has been resolved. Github automatically creates redirects for renamed repos, so existing usages should still be fine.
The README in the go-client
repo has an updated example that shows it cleaned up as well.
from fusionauth-client-builder.
@matthew-altman just in case... make sure you also update the Go doc page.
https://fusionauth.io/docs/v1/tech/client-libraries/go
from fusionauth-client-builder.
Thanks @GrimTheReaper the help is appreciated!
@matthew-altman can you take a look at these issues, perhaps open another issue to track.
from fusionauth-client-builder.
Related Issues (12)
- KeyId misspelled in deleteKey.json
- PKCE parameter isn't allowed in the generated exchangeOAuthCodeForAccessToken method
- Crystal language support? HOT 3
- Userinfo endpoint HOT 6
- go-client: run `go fmt` after code generation. HOT 1
- Support anonymous resend of email verification
- src/main/domain/io.fusionauth.domain.User.json missing username field HOT 3
- Class Generation HOT 1
- Dart Client Build removal
- Incorrect successResponse on /api/user/comment
- Savant won't generate client code on Windows HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fusionauth-client-builder.