Giter VIP home page Giter VIP logo

Comments (8)

GrimTheReaper avatar GrimTheReaper commented on August 20, 2024 1

Neat. The only other weird oddity for the Go package is that everything is under pkg. Usually, if a repo is just a library and not an application, the resources are under root. A good(ish) example can be found here, although I wouldn't say that it is important enough to break existing changes.

Also while I was glancing about, I noticed that the README example has invalid go syntax, so I fixed that for you FusionAuth/go-client#10

from fusionauth-client-builder.

robotdan avatar robotdan commented on August 20, 2024

@GrimTheReaper this is just our pattern thus far.

@matthew-altman Any potential issues you see with a change such as this?

from fusionauth-client-builder.

matthew-altman avatar matthew-altman commented on August 20, 2024

@robotdan It's a matter of renaming every client repo. Not hard, but there would be a lot of downstream repo changes as well...maven, npm, etc

from fusionauth-client-builder.

robotdan avatar robotdan commented on August 20, 2024

@matthew-altman what about just for Go, is the package stuttering an issue with Go?

from fusionauth-client-builder.

matthew-altman avatar matthew-altman commented on August 20, 2024

@robotdan No problem changing it for Go. It's not an issue, per se, but isn't idiomatic. I'll see what I can do.

from fusionauth-client-builder.

matthew-altman avatar matthew-altman commented on August 20, 2024

This has been resolved. Github automatically creates redirects for renamed repos, so existing usages should still be fine.
The README in the go-client repo has an updated example that shows it cleaned up as well.

from fusionauth-client-builder.

robotdan avatar robotdan commented on August 20, 2024

@matthew-altman just in case... make sure you also update the Go doc page.
https://fusionauth.io/docs/v1/tech/client-libraries/go

from fusionauth-client-builder.

robotdan avatar robotdan commented on August 20, 2024

Thanks @GrimTheReaper the help is appreciated!

@matthew-altman can you take a look at these issues, perhaps open another issue to track.

from fusionauth-client-builder.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.