Comments (4)
Suggest using the public suffix list https://publicsuffix.org/list/public_suffix_list.dat which will resolve this issue going forward for more than the co.uk domain.
I don't know how often that file changes, but it's licensed liberally and maintained.
from fusionauth-issues.
https://publicsuffix.org/list/
If you wish to make your app download an updated list periodically, please use this URL and have your app download the list no more than once per day. (The list usually changes a few times per week; more frequent downloading is pointless and hammers our servers.)
The public suffix approach resolves this issue but does not resolve the related issue where a registrable domain has multiple FusionAuth deployments hosted on different subdomains or multiple domains that point to the same FusionAuth deployments.
from fusionauth-issues.
I agree that it doesn't fix the related issue. But the related issue feels more like an enhancement, so I'd advocate solving it in a backwards compatible manner.
I also think we could take a subset of the public suffix list. We don't need to work with every one. We could take all the ICANN domains, or even just all the domains that have a two letter root domain (like the .ac and .uk ones).
I'd advocate for solving this bug in the right way, and solving #2479 via configuration in a backwards compatible way.
from fusionauth-issues.
Internal
from fusionauth-issues.
Related Issues (20)
- Kickstart not usable because of default email templates added HOT 2
- `federated.csrf` cookie is not created in some cases HOT 1
- Feature Request: Read-Only Admin Role in FusionAuth HOT 1
- An empty name and empty value cookie is being set (HttpOnly) HOT 1
- [Bug]: Incorrect redirect uri query parameters for oauth error redirects when the redirect uri has a query parameter configured
- OAuth error condition does not append to redirect correctly. HOT 1
- Lack of GDPR Compliance Options in New WYSIWYG Editor HOT 1
- [Bug]: Simple Theme misses date-picker styling HOT 1
- Add a Support Role to Account Portal Users HOT 1
- Homebrew install fails with `NoMethodError` HOT 1
- Add copy button to all certificate/key fields in keymaster HOT 1
- [Bug]: Non-ASCII HTTP header values are not supported HOT 4
- Allow me to return to completed first-time setup steps and possibly edit details
- [Bug]: Race condition on startup HOT 3
- [Bug]: Saving Simple Theme in Admin UI return 415 error
- [Bug]: Custom message keys added via the simple theme editor will not persist on save
- Add product version to the Prometheus Metrics endpoing HOT 2
- [Bug]: Improve gated verification experience
- Add session timeout to a Group HOT 2
- [Bug]: The description for the user password reset send webhook has a typo in it HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fusionauth-issues.