Giter VIP home page Giter VIP logo

Comments (7)

mooreds avatar mooreds commented on July 24, 2024 1

Hmmm. Based on my limited understanding of golang, it looks like we'd want to set the type of the User field in the RegistrationRequest to *User so it could be nillable and thus omitted when optionall. I think that would happen here: https://github.com/FusionAuth/fusionauth-client-builder/blob/master/src/main/client/_macros.ftl#L36 but would need to test it more (because I think we'd need to dereference the pointer elsewhere).

I would imagine this would be an issue for other request structs which have optional objects nested, such as ApplicationRequest.

from go-client.

mooreds avatar mooreds commented on July 24, 2024 1

Does the workaround mentioned above work for you @Tintwo ?

from go-client.

Tintwo avatar Tintwo commented on July 24, 2024

I have exactly the same problem as vkorn.
Method "Register" has 2 modes : user+registration or registration-only. But impossible to use the 2nd one, the client try to create an user (which is nil because we don't want to create an user but use an existing user id)

When I look here :

User User `json:"user,omitempty"`

we can see this field shouldn't appear in the generated JSON body if not provided when we create the RegistrationObject (but apparently it does).

from go-client.

Tintwo avatar Tintwo commented on July 24, 2024

For now I dupplicate the Register method and change the RegistrationRequest by a custom one (without the user). It's a pretty similar workaround (dupplicate code :/)

from go-client.

benkloester avatar benkloester commented on July 24, 2024

@mooreds we have run into this issue as well. We are pursuing the workaround for now but would be really keen to see the root cause addressed.

Also keen to understand whether we will run into the issue raised in #1576 or if the workaround avoids that problem.

Should we lodge a support ticket re this issue?

from go-client.

robotdan avatar robotdan commented on July 24, 2024

@mooreds or @benkloester is this a simple change to how we are building the domain objects in go so that the User reference in RegistrationRequest is *User ?

User User `json:"user,omitempty"`

from go-client.

benkloester avatar benkloester commented on July 24, 2024

That go-client is generated code, produced by fusionauth-client-builder, so the fix would really need to be in the builder or it will get clobbered.

From the answer he gave above it seems like @mooreds had an idea of where one of the necessary changes would be, but there was a bit more to be figured out and there was also a need to test any such change.

from go-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.