Comments (8)
Django-improved-user argues that it's better to store the e-mail addresses in a case sensitive field and use case-insensitive queries to filter for a match: https://django-improved-user.readthedocs.io/en/latest/email_warning.html
@aidanlister's example seems to cover that, but he might also need to have an index on lower(email::text)
to prevent duplicates? Without the unique index, another user might be able to create an uppercase version of an existing e-mail and have it match.
Although the first part of the e-mail is supposed to be case sensitive (according to RFC 5321), I don't know of any e-mail providers that actually do that. So maybe it doesn't matter?
from django-authtools.
A functional index on UPPER(email)
would be the ideal solution on postgres, but we'd have to use email__iexact
everywhere, and lookups by email wouldn't be indexed at all on mysql.
from django-authtools.
Maybe we could do get by with just dbindex=True
and do our normalization outside of the database. Something similar to what BaseManager
does here
Is there a problem just calling .lower()
or .upper()
on the address part of the email?
from django-authtools.
https://github.com/fusionbox/django-authtools/blob/master/authtools/models.py#L14
Is there anything we can do?
from django-authtools.
This is a bit of a trouble spot for users entering emails in interesting ways. 👍 for any fix..
from django-authtools.
#31 won't work for anyone on Postgres.
It simply does a .lower() on the incoming login, but not the database User.get operation. So if there's a capitalised email in the database it's impossible to login.
from django-authtools.
Here's a better way:
class AccountManager(models.Manager):
def get_by_natural_key(self, username):
field_name = f'{self.model.USERNAME_FIELD}__iexact'
return self.get(**{field_name: username})
Set this on your custom user model.
from django-authtools.
Isn't that handled by CaseInsensitiveEmailBackendMixin?
from django-authtools.
Related Issues (20)
- Use with django-axes not supported HOT 2
- Request object not passed in login HOT 1
- Support Django 3.0 HOT 7
- Signature of create_superuser() not allways compatible with Django's own HOT 1
- AbstractEmailUser does not normalize emails HOT 2
- Docs out of date: `schemamigration` does not exist anymore HOT 1
- Handling of SMTPRecipientsRefused exception
- Project continuity HOT 3
- Django >= 3.2 creating new migrations HOT 1
- pkg_resources deprecation warning HOT 2
- New stable release HOT 3
- Change password link broken again HOT 1
- I think pip installation doesn't install lastversion.
- How to sign in with both username or email using django-authtools? HOT 1
- Authtool not recognized in AWS deployment HOT 1
- Authtools' user model doesn't work with utf8mb4 on MariaDB/MySQL HOT 1
- User password change link HOT 2
- Use a namespace? HOT 1
- BetterReadOnlyPasswordHashWidget is broken for view only users
- is_authenticated() no longer supported in Django 2.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-authtools.