Giter VIP home page Giter VIP logo

Comments (4)

moreati avatar moreati commented on June 22, 2024

An experiment https://github.com/moreati/django-tests, so far unpublished on PyPI

from django-authtools.

rockymeza avatar rockymeza commented on June 22, 2024

Hi,

I think that these are all good ideas, but there is one problem that has
been bugging me for a while.

Lots of Django's auth tests are wrapped in a skipIfCustomUser (or
something like that), which actually means that lots of the tests don't
actually run when we are using custom User models.

We were thinking about just copying the tests into django-authtools and
editing them to remove the skipIfCustomUser decorations, but I think the
maintenance burden of that is a bit larger than we really want to take on.
We also lose the security upgrade guarantees that are provided by relying
directly on Django's tests.

What do you think?

-rocky

On Mon, Sep 14, 2015 at 5:20 AM, Alex Willmer [email protected]
wrote:

An experiment https://github.com/moreati/django-tests, so far unpublished
on PyPI


Reply to this email directly or view it on GitHub
#53 (comment)
.

from django-authtools.

moreati avatar moreati commented on June 22, 2024

Lots of Django's auth tests are wrapped in a skipIfCustomUser

From a cursory grep, that might not be the case in Django 1.8.x

alex:~/src/django-tests $ ag "skipIfCustomUser"
vendor/django/django/contrib/auth/tests/utils.py
6:def skipIfCustomUser(test_func):

vendor/django/docs/topics/auth/customizing.txt
908:``django.contrib.auth.tests.utils`` defines a ``@skipIfCustomUser`` decorator.
933:    from django.contrib.auth.tests.utils import skipIfCustomUser
939:        @skipIfCustomUser

from django-authtools.

acatton avatar acatton commented on June 22, 2024

Done in #56 , merged, released in 1.4.0.

from django-authtools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.