Giter VIP home page Giter VIP logo

Comments (4)

fwextensions avatar fwextensions commented on June 7, 2024

Thanks very much for the detailed bug report!

I found out that for some reason, extensions' shortcuts are written with spaces around + sign.

I've never seen that on Windows or Mac (which has its own annoyingly different way of storing the shortcuts). What browser version and OS are you on? I'm guessing Linux or ChromeOS?

If you go to the Extensions page and enable Developer mode in the top right, you can inspect the background.html page under QuicKey. In the console there, you can run chrome.commands.getAll(console.log) to see how Chrome returns the shortcuts to the extension. I'm guessing you'll see the spaces in that response.

from quickey.

antshar avatar antshar commented on June 7, 2024

I'm on Windows 10 and I use one of chromium forks, however, I don't think spaces in shortcuts were added intentionally. Maybe it's a feature of one of chromium builds.

Yes, you are right, if run chrome.commands.getAll(console.log) I get the following
image

In case someone else face this problem in their browser, I think it worth adding such a small change as .replace(/\s/g, '') just in case.

from quickey.

fwextensions avatar fwextensions commented on June 7, 2024

Thanks for confirming. That's very weird. Which chromium fork is it? I wonder if it's something that will come to Chrome eventually, or if it's made its way into the Mac build of that fork.

Definitely something to fix. I think I'll make the ShortcutSeparator constant a regex that includes optional spaces, and use that to split the strings.

from quickey.

antshar avatar antshar commented on June 7, 2024

I'm using Cent Browser because of its great customization. However, it doesn't update so often, so the latest version has been built with Chromium: 86.0.4240.198

from quickey.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.