Intermittent: Failed to load ‘https://knilxof.org:4443/ping’. A ServiceWorker passed a promise to FetchEvent.respondWith() that rejected with ‘TypeError: NetworkError about app HOT 12 OPEN

@arcturus It seems the SW is correctly registered but can't fetch the content of https://knilxof.org:4443/ping. Would it be possible to print out what's the response given?

from app.

@JohanLorenzo you can enable debug on SW following the next steps to build a version of the library with debug:

• go to node_modules/serviceworkers-ware
• npm install
• gulp bundle-debug

And rebuild the app

from app.

Looking at this.

from app.

Hey @JohanLorenzo what I see is that https://knilxof.org:4443/ has invalid certificate that's why we can't get any data from it. Once you add exception - it works fine.

Or you see something different?

from app.

Note I'm using your PR #161 locally

from app.

Also I'm wondering why do we need real registration server?

I feel tests will be too flaky if we rely on external thing....

from app.

That might be it. One one hand, https://knilxof.org:4443/ may not be an issue because it intermittently passed. On the other hand, that's one clear change between the old tests set up and the new one.

If that's the problem, re-issuing a Let's Encrypt certificate should make the PR pass for the next few days. I remember @gmarty and @michielbdejong were talking about it, last week. I don't recall if it was addressed, though.

On your second point, I agree the real registration server shouldn't be used. That's a good follow up, IMO.

So, I'd propose we fix the certificate on knilxof and see if it makes things better. If not, we change mock out the registration server.

from app.

If that's the problem, re-issuing a Let's Encrypt certificate should make the PR pass for the next few days.

I'm not sure if that's enough :) I suspect that your PR is relying on real foxbox instance now and its signup and login pages are quite different from what we had in simulator. I didn't go through your PR so maybe you already have necessary changes in tests, if so that's great!

On your second point, I agree the real registration server shouldn't be used. That's a good follow up, IMO.
So, I'd propose we fix the certificate on knilxof and see if it makes things better. If not, we change mock out the registration server.

Yep, it can surely be a follow-up, agree.

So @michielbdejong could you please help with updating certificate at https://knilxof.org:4443/?

from app.

So nothing to do for me here, unassigning.

from app.

I'm not sure if that's enough :) I suspect that your PR is relying on real foxbox instance.

The PR hasn't (shouldn't have 😃 ) changed the role of the simulator. We still use it for the integration tests.

from app.

OK then I think I'm missing something in the integration tests setup.. Let's talk on irc once you come back from London :)

from app.

re-issuing a Let's Encrypt certificate should make the PR pass for the next few days. I remember @gmarty and @michielbdejong were talking about it, last week. I don't recall if it was addressed, though.

It was, current certificate is valid 3 June - 1 Sep 2016, you can check this by viewing the padlock details on https://knilxof.org:4443/.

from app.