Bug: compilation error with Sass and Symfony Webpack Encore about fylgja HOT 4 CLOSED

Hi @bricebou I need to check why this is happening for this specific case.

Most likely the it an issue with sass-loader or encore or both, not sure yet.

I will first do a test, when I have time, of a clean install with just webpack and sass-loader
If this still works I will try using the full case, with encore.

The issue on top is error from sass-loader that it can not find @use "@fylgja/mq/helper", this error normally always relates to that the relative path is not set for /node_modules/.

See the Sass docs for load-path:

• https://sass-lang.com/documentation/cli/dart-sass#load-path
• https://sass-lang.com/documentation/js-api/interfaces/Options#loadPaths

This weird since your own imports are using the relative path node_modules.
so this clearly a error somewhere and needs a bit of testing why.

from fylgja.

Thanks a lot ! I'll stay available if you need me to send more logs or test more :)

from fylgja.

Hi @bricebou, I believe I may have found a solution to your issue. It appears that you need to set the include path to ensure that all node relative paths are handled correctly when using sass-loader.

The problem seems to be related to how sass-loader handles imports from node_modules. In both cases that I tested (with Webpack and Encore), passing includePaths: ["node_modules"] was necessary, just like when using sass directly.

To fix your issue, please add the following code to your configuration:

const Encore = require('@symfony/webpack-encore');

// Other Encore options

Encore
  // Other Encore options

  .enableSassLoader((options) => {
    options.sassOptions = {
      includePaths: ["node_modules"],
    };
  }, {})
;

module.exports = Encore.getWebpackConfig();

Thank you for bringing this issue to my attention. I have also created a repository specifically for JS bundler cases like this, which you can find at fylgja/examples. I will add more options there later 😉.

from fylgja.

Great, thanks a lot @GrimLink ! I'll try that as soon as I can :-)

from fylgja.