Giter VIP home page Giter VIP logo

Comments (13)

rufoa avatar rufoa commented on June 14, 2024 5

Hi guys, sorry the lack of timbre 5 support is causing annoyance. I have most of the code ready but have been very short of time recently due to work. I hope to be able to dedicate some time to getting this finished soon, and will announce here when it is ready. Thanks for your continued patience.

from slf4j-timbre.

rufoa avatar rufoa commented on June 14, 2024 1

I have successfully reproduced this issue and have identified the root cause. It is a consequence of timbre renaming :level to :min-level in 5.0.0.

When slf4j-timbre is compiled (against timbre 4.10.0), the line (timbre/with-level :info ...) macro-expands to (assoc *config* :level :info).

At runtime, your project (with timbre 5 on the classpath) reads the value of :min-level, which is not set, so defaults to :debug.

I will try to figure out the best way to solve this.

from slf4j-timbre.

jsyrjala avatar jsyrjala commented on June 14, 2024

Are there any known issues with timbre 5.0.0? At least we are seeing libraries using slf4j to logging at DEBUG level with timbre 5.0.0, when they didn't with timbre 4. with slf4j-timbre 0.3.19

from slf4j-timbre.

rufoa avatar rufoa commented on June 14, 2024

Thanks for letting me know. I haven't yet tested slf4j-timbre with timbre 5.0.0. I will investigate this issue ASAP

from slf4j-timbre.

rufoa avatar rufoa commented on June 14, 2024

@jsyrjala please try 0.3.20!

from slf4j-timbre.

jsyrjala avatar jsyrjala commented on June 14, 2024

I tried 0.3.20 and we are still seeing debug logs with timbre 5.x and not seeing them with timbre 4.x.

from slf4j-timbre.

rufoa avatar rufoa commented on June 14, 2024

That is very strange 😕

Please could you give me as much detail as possible about how your project is triggering this behaviour? A small test case would be ideal.

Many thanks

from slf4j-timbre.

awb99 avatar awb99 commented on June 14, 2024

I use it with timbre v5, but I get this warning printed in console:

SLF4J: Class path contains SLF4J bindings targeting slf4j-api versions prior to 1.8.
SLF4J: Ignoring binding found at [jar:file:/home/andreas/.m2/repository/com/fzakaria/slf4j-timbre/0.3.21/slf4j-timbre-0.3.21.jar!/org/slf4j/impl/StaticLoggerBinder.class]

from slf4j-timbre.

devurandom avatar devurandom commented on June 14, 2024

I use it with timbre v5, but I get this warning printed in console:

SLF4J: Class path contains SLF4J bindings targeting slf4j-api versions prior to 1.8.
SLF4J: Ignoring binding found at [jar:file:/home/andreas/.m2/repository/com/fzakaria/slf4j-timbre/0.3.21/slf4j-timbre-0.3.21.jar!/org/slf4j/impl/StaticLoggerBinder.class]

What you are seeing is probably #45.

from slf4j-timbre.

masterbuilder99 avatar masterbuilder99 commented on June 14, 2024

Any update on updating this library to timbre v5?

from slf4j-timbre.

awb99 avatar awb99 commented on June 14, 2024

@rufoa I see you have forked this repo. Is your fork working? I find it very annoying that since timbre 5 this library did break don. It really should be a simple thing... What could be done is to make a different artefact, and then the different timbre versions are easily visible.

from slf4j-timbre.

awb99 avatar awb99 commented on June 14, 2024

Hi! Any news in this?

from slf4j-timbre.

rufoa avatar rufoa commented on June 14, 2024

@awb99 yes! Please try out the new snapshot and let me know if it works for you.

I've not yet finished my overhaul of the integration tests, which should give me more confidence that everything works with different library versions and configurations. But I can't keep you waiting for that!!

from slf4j-timbre.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.