Comments (3)
I think that is implicitly done (DataView.hpp
):
if (this->offset + this->count > array.dataExtent()) {
throw OutOfBounds("Trying to create DataView which is out of bounds");
}
Because comparing the NDSize
(offset + count
) with dataExtent()
will check the dimensionality:
template<typename T>
inline bool NDSize::operator<(const NDSizeBase<T> &lhs, const NDSizeBase<T> &rhs)
{
if (lhs.size() != rhs.size()) {
throw IncompatibleDimensions("size must agree to compare",
"NDSizeBase < NDSizeBase ");
}
from nix.
You're right. Didn't think to check that.
Would you like to add an explicit check? If you think the check in the comparison is enough, just close the issue.
from nix.
Would you like to add an explicit check? If you think the check in the comparison is enough, just close the issue.
I think that would be better, yeah, an IncompatibleDimensions
with a more specific error message.
from nix.
Related Issues (20)
- Port to C++17
- Optimize reading of old style values
- Add UUIDs to File objects HOT 1
- UTF-8 for strings
- Bump file format version HOT 1
- MultiTag: Convenience constructor that doesn't require DataArray HOT 1
- Reorganise documentation HOT 2
- Wildcard tagging
- Build fails with Boost 1.71 HOT 2
- Tagging DataArrays with different dimenisionalities HOT 3
- Tag extent behaviour [discussion] HOT 1
- Functions for Column Dimensions HOT 3
- DataFrame: need API to query number of colums without fetching the column
- DataFrame: need API to get a single column
- Update Appveyor configuration
- Tag data retrieval specification HOT 2
- Dimensions with linking for ticks and labels
- outdated wiki information HOT 2
- new h5py version doesn't support numerical event labels HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nix.