ManagedRandomAccessFile: A callback was made on a garbage collected delegate about parquetsharp HOT 4 CLOSED

Hi @delreluca, yes your explanation for what is happening is correct. ManagedRandomAccessFile is IDisposable so it's intended to be used with a using statement and only disposed after it is no longer needed.

This isn't the first time someone has run into this issue though, see #266 for example. So it would probably make sense for ParquetFileReader to keep a handle to the RandomAccessFile to avoid this issue. And similarly, ParquetFileWriter should keep a handle to an OutputStream when one is used.

from parquetsharp.

This has been fixed on master now, you should still dispose of the ManagedRandomAccessFile yourself with a using statement, but ParquetSharp should no longer crash if you don't.

from parquetsharp.

Ah, I missed that issue, sorry. Thanks for confirming my explanation, I can just fix my code with the additional using then.

I would welcome remembering the handle since I would have expected an IDisposable to also dispose of whatever it received as a reference in its constructor. (Not sure if that is a written best practice? Just a gut feeling)

from parquetsharp.

I'm not sure it makes sense for ParquetFileReader/Writer to actually dispose of the ManagedRandomAccessFile or OutputStream. That would be a breaking change if someone is relying on being able to reuse them afterwards. But it seems sensible for the reader and writer to just hold a reference to prevent these objects from being garbage collected while in use.

from parquetsharp.