Giter VIP home page Giter VIP logo

Comments (3)

gottfriedleibniz avatar gottfriedleibniz commented on July 17, 2024

GLSL defines min as:

Returns y if y < x; otherwise it returns x

which should match std::min's behaviour (not std::fmin). Unfortunately, the inconsistency in special-value behaviour between IEEE-operators vs ternary-logic will emerge elsewhere too.

from glm.

christophe-lunarg avatar christophe-lunarg commented on July 17, 2024

Erm, the comment, the example don't match. Without clarification, I will just close this issue. Maybe that's a feature request for a fcompMin function. unclear.

from glm.

MaxSac avatar MaxSac commented on July 17, 2024

Sorry for the incorrect minimal working example. I wrote it yesterday in a hurry and have now corrected it.

To give a little bit of background.
I tried to calculate the interaction distance from a ray to a box, as sketched in the picture.
sketch-1

I wrote the following code and was quite surprised that a) and b) gave different results.

#include <array>
#include <glm/glm.hpp>
#include <glm/gtx/component_wise.hpp>
#include <iostream>
#include <limits>

std::array<float, 2> intersection(glm::vec2 corner1, glm::vec2 corner2,
    glm::vec2 origin, glm::vec2 invDirection)
{
    auto tMin = (corner1 - origin) * invDirection;
    auto tMax = (corner2 - origin) * invDirection;

    auto tEnter = glm::min(tMin, tMax);
    auto tExit = glm::max(tMin, tMax);

    auto enterMax = glm::compMax(tEnter); 
    auto exitMin = glm::compMin(tExit);  

    return std::array<float, 2> { enterMax, exitMin };
}

int main(int argc, char* argv[])
{
    auto c1 = glm::vec2(1, 1);
    auto c2 = glm::vec2(2, 2);

    // a)
    auto origin1 = glm::vec2(1, 0);
    auto invDirection1 = glm::vec2(std::numeric_limits<float>::quiet_NaN(), 1.f);
    auto intersection_points1 = intersection(c1, c2, origin1, invDirection1);
    std::cout << "entry: " << intersection_points1[0] << ", exit: " << intersection_points1[1] << std::endl;
    // >>> entry: nan, exit: nan


    // b)
    auto origin2 = glm::vec2(0, 1);
    auto invDirection2 = glm::vec2(1.f, std::numeric_limits<float>::quiet_NaN());
    auto intersection_points2 = intersection(c1, c2, origin2, invDirection2);
    std::cout << "entry: " << intersection_points2[0] << ", exit: " << intersection_points2[1] << std::endl;
    // >>> entry: 1, exit: 2

    return 0;
}

Technically I can understand what happens, but it was against my naive expectation.
I guess using something like fcompMax would help in this case and would be a nice feature.

from glm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.