Comments (3)
GLSL defines min as:
Returns y if y < x; otherwise it returns x
which should match std::min
's behaviour (not std::fmin
). Unfortunately, the inconsistency in special-value behaviour between IEEE-operators vs ternary-logic will emerge elsewhere too.
from glm.
Erm, the comment, the example don't match. Without clarification, I will just close this issue. Maybe that's a feature request for a fcompMin
function. unclear.
from glm.
Sorry for the incorrect minimal working example. I wrote it yesterday in a hurry and have now corrected it.
To give a little bit of background.
I tried to calculate the interaction distance from a ray to a box, as sketched in the picture.
I wrote the following code and was quite surprised that a) and b) gave different results.
#include <array>
#include <glm/glm.hpp>
#include <glm/gtx/component_wise.hpp>
#include <iostream>
#include <limits>
std::array<float, 2> intersection(glm::vec2 corner1, glm::vec2 corner2,
glm::vec2 origin, glm::vec2 invDirection)
{
auto tMin = (corner1 - origin) * invDirection;
auto tMax = (corner2 - origin) * invDirection;
auto tEnter = glm::min(tMin, tMax);
auto tExit = glm::max(tMin, tMax);
auto enterMax = glm::compMax(tEnter);
auto exitMin = glm::compMin(tExit);
return std::array<float, 2> { enterMax, exitMin };
}
int main(int argc, char* argv[])
{
auto c1 = glm::vec2(1, 1);
auto c2 = glm::vec2(2, 2);
// a)
auto origin1 = glm::vec2(1, 0);
auto invDirection1 = glm::vec2(std::numeric_limits<float>::quiet_NaN(), 1.f);
auto intersection_points1 = intersection(c1, c2, origin1, invDirection1);
std::cout << "entry: " << intersection_points1[0] << ", exit: " << intersection_points1[1] << std::endl;
// >>> entry: nan, exit: nan
// b)
auto origin2 = glm::vec2(0, 1);
auto invDirection2 = glm::vec2(1.f, std::numeric_limits<float>::quiet_NaN());
auto intersection_points2 = intersection(c1, c2, origin2, invDirection2);
std::cout << "entry: " << intersection_points2[0] << ", exit: " << intersection_points2[1] << std::endl;
// >>> entry: 1, exit: 2
return 0;
}
Technically I can understand what happens, but it was against my naive expectation.
I guess using something like fcompMax
would help in this case and would be a nice feature.
from glm.
Related Issues (20)
- Build (tests) fails with -Werror due to a lot of warnings HOT 4
- Build fails with clang on GLM_DEPRECATED GLM_FUNC_DECL construct HOT 4
- Please restore glm.pc HOT 1
- GLM shared doesnt export DLL symbols HOT 3
- Compiler warnings (error: unsafe buffer access)
- are there any gdb pretty printers for the glm library? HOT 1
- is glm::cubic broken?
- CUDA compilation error: dot and vector multiplication functions use STL and cause compilation error.
- Wrong vector addition result inside a Cuda kernel. HOT 1
- 1.0.1: build fails with `GLM_TEST_ENABLE=ON` HOT 3
- Where can I find the implementation code for `glm::mat4 * glm::vec4`? HOT 1
- Compile Error MSVC
- Update fetch content CMake example to point to correct tag
- Enhance glm::dualquat and singular value decomposition for square matrix
- AVX2 on glm::vec4 and not on glm::vec3
- 'quat_cast': identifier not found when using glm as C++20 module
- Issue: Example Commands in README.md, in 'Build and Install' section, Label: Documentation
- What is glm-light?
- glm-1.0.1-light identifies itself as version 1.0.0
- Official build2 Package
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glm.