Giter VIP home page Giter VIP logo

Comments (5)

payne-chris-r avatar payne-chris-r commented on August 28, 2024 1

Yes, people (talking only about myself) know it. Though sometimes the "duplicating" work takes less time than reviewing an old branch that may or may not be up-to-date anyway. If it resolves issues it's one thing, if it's just a template update and I have to do it anyway for the current iteration, why bother reviewing the stale branch when I'm going to have to do it again anyway? To me that feels more like duplicating work than just doing it from a template that I know is up to date?

from rails-api-study.

jrhorn424 avatar jrhorn424 commented on August 28, 2024

@tvlangley @payne-chris-r Any idea what happened here? Was @bernardlee's PR ignored or was it used as a basis for the update in 8ab7311?

from rails-api-study.

MicFin avatar MicFin commented on August 28, 2024

Looks like it was used in the commit
8ab7311#diff-2fc0e52245764239acae01b60cc3dc7cL38

from rails-api-study.

jrhorn424 avatar jrhorn424 commented on August 28, 2024

@MicFin I'm specifically asking whether effort was duplicated.

What I really care about is: Do people know that they should look at open PRs when prepping as part of the process?

from rails-api-study.

tvcrawley avatar tvcrawley commented on August 28, 2024

I used the existing PR as a basis for my PR.

from rails-api-study.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.