Comments (2)
Ok, I can definitely clarify that rationale better, or tone down the dismissive language. It may actually be useful to try to dissuade people from using this, because, in my opinion, using this is a bad move that is less useful than using the other, better features of sequence collections. So, I think the dismissive language here may be warranted and useful and instructive, but I haven't effectively explained why/the alternative.
To understand your use case, one thing I'm confused about: You're looking to compare coordinate spaces:
"do these resources represent variants in the same coordinate space?".
But then wouldn't you use sorted_name_length_pairs
? It's exactly for looking for shared coordinate systems. I guess you're saying you don't have sequence names -- but if there are no sequence names, then you don't have a coordinate space at all, and I don't see how you have variant definitions, either. How can you describe variants without sequence name? The variants have to annotate a certain sequence in the collection. So I'm missing your point here. You'd need sequence names, and sorted_sequences
won't help you anyway, right?
A few other thoughts:
- You're neglecting the complexity of subsets -- what if one collection has an additional sequence added? Then the digests won't match anyway. I think you're overestimating the probability that people have different collections with the same sequence content, but in different order and with different names and no extra or missing sequences in the collection, which are the requirements you'd need to match on
sorted_sequences
. On the other hand, all this information is immediately provided by the comparison function. - The comparison function can be calculated even if the service only recognizes one of the digests, as long as you have the canonical representation of the other. If you don't have either representation, then that's where you have the problem. For that situation, we would need 'meta-servers' that broker digest requests to servers. But I think even if you're using sorted_sequences, you're still going to be in this situation a lot of the time, due to the above point.
from refget.
I toned down the dismissive language in the ADR :)
from refget.
Related Issues (20)
- Identifier construction: To prefix or not to prefix HOT 11
- Define what the service info will contain HOT 11
- Discussion on undigested attributes and sorted-name-length-pairs HOT 20
- RFC-8785 and refget compatibility HOT 1
- Alphabet as inherent property of a sequence collection HOT 2
- Reserved namespace policy for future extension of SeqCol HOT 1
- Terminology round 2 HOT 3
- Minimal and extended schemas proposal
- Should we prefix the digests that we return from seqcol? HOT 2
- How to store and represent and compare non collated single value attributes in a sequence collection HOT 9
- Identifier vs digest in the specs HOT 2
- List endpoint and pagination HOT 10
- Add sorted_sequences as recommended non-inherent attribute HOT 4
- Should lengths and names be required properties in every sequence collection ? HOT 13
- Documentation request- seqcol without sequences HOT 2
- Test suite?
- Use case: a digest for a collection of sequences HOT 4
- New schema term: accessions
- Proposal: the attribute endpoint HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from refget.