Giter VIP home page Giter VIP logo

Comments (4)

le717 avatar le717 commented on August 20, 2024

@shallaa No, Chome OS is not detected, but try this edit I just made on my fork after looking up the Chrome OS UA for double checking.
https://github.com/le717/jquery-browser-plugin/blob/2860e5e5c68bc62ca74d6e4901564b4a6c58cbce/dist/jquery.browser.js
From inspection, it looks like the key will be $.browser.cros. I also added it to the CoffeeScript code, but IDK if it will work (I do not know how to code in CoffeeScript). Let me know if it works. I'll submit a PR for @gabceb to review. πŸ˜‰

from jquery-browser-plugin.

gabceb avatar gabceb commented on August 20, 2024

We should add this to the project @le717. Are you going to send a PR with your changes?

from jquery-browser-plugin.

le717 avatar le717 commented on August 20, 2024

Yes, I will send a PR for this feature. I was waiting on @shallaa to confirm it worked first (I have no way to test it myself short of doing a UA swap myself, which I think I will...).

from jquery-browser-plugin.

gabceb avatar gabceb commented on August 20, 2024

Try following the directions on how to set the test environment and change if needed. Otherwiser you can just send me your code on a PR and I will make sure it works by creating test cases and trying it out.

from jquery-browser-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.