static willTransitionTo is lost about babel-plugin-react-transform HOT 7 CLOSED

Please provide a reproducible example. Babel plugin doesn't add any HOCs.

from babel-plugin-react-transform.

Ok, i investigated some more.
The problem is the following:
We use fluxible, which provides the provideContext helper, which wraps your root component by returning a HOC that injects context into its its wrapped component. it copies over statics by using hoist-non-react-statics, which in turn uses var keys = Object.getOwnPropertyNames(sourceComponent) to get the relevant statics (see source). When console.logging those keys without using this plugin, this returns an array that contains "willTransitionTo". When using with this plugin, the array doesn't contain "willTransitionTo" (just ["length", "name", "arguments", "caller", "prototype", "displayName", "__reactPatchProxy", "contextTypes"]).

I am not sure if this is expected behaviour, as I do not entirely understand the limitations section of your react-proxy README:

Does not replace ES7 instance properties
Does not replace bound static methods
Replacing a method using autobind-decorator causes its identity to change

(I don't find google results for "ES7 instance properties" and "bound static methods" -- excuse my ignorance :))

from babel-plugin-react-transform.

Closing as duplicate of gaearon/react-proxy#23.

from babel-plugin-react-transform.

Ok thanks for confirming, will watch there!

from babel-plugin-react-transform.

Just to clarify—this is not related to limitations in README, those are only talking about what's hot reloaded. The problem is a side effect of the way static properties are currently being proxied.

from babel-plugin-react-transform.

Thank you for reporting this.
It should be fixed in [email protected] via [email protected] (gaearon/react-proxy#29).
Please verify.

from babel-plugin-react-transform.

Awesome. Works! Thank you so much. :) deploying react-transform to all of
our projects now. Yey :)

Dan Abramov [email protected] schrieb am Fr., 25. Sep. 2015 22:17:

Thank you for reporting this.
It should be fixed in [email protected] via [email protected] (
gaearon/react-proxy#29 gaearon/react-proxy#29).
Please verify.

—
Reply to this email directly or view it on GitHub
#25 (comment)
.

from babel-plugin-react-transform.