[Relay] Support for Relay GraphQL needed. about babel-plugin-react-transform HOT 5 CLOSED

This will probably be solved by #26 when it's implemented.

Can you please say whether it works with React Hot Loader?

from babel-plugin-react-transform.

@gaearon It didn't work for me. I hope your big rewrite for babel 6 compatibility will fix this issue too.
Thanks
Bernd

from babel-plugin-react-transform.

As a quick hack, I changed getDisplayName to:

  function getDisplayName(node) {
    if (node.arguments[0].properties) {
      const property = find(node.arguments[0].properties, node => node.key.name === 'displayName');
      return property && property.value.value;
    } else {
      return node.arguments[0].name;
    }
  }

And I updated my babel plugin config with the following:

[
  "react-transform",
  {
    "transforms": [
      {
        "transform": "react-transform-hmr",
        "imports": [
          "react"
        ],
        "locals": [
          "module"
        ]
      }
    ],
    "factoryMethods": ["React.createClass", "Relay.createContainer"]
  }
]

This makes it so hotloading will work when using Relay. It won't reload your fragments and re-fetch data... But it enables you to at least iterate on components, so I'd view it as an improvement.

from babel-plugin-react-transform.

I’m curious whether the approach from reduxjs/redux#1455 might help here. Namely, just nuke your components and mount new versions of them without React Transform altogether.

from babel-plugin-react-transform.

@BerndWessels

Thanks again for raising this.
I’m closing because you have several options:

• try the workaround I described in #45 (comment)
• wait for some solution to #26 which looks like one possible cause of this issue
• take the time to dive in, figure out why it doesn’t work, and maybe contribute that support 😉

I don’t plan to personally work on this in near term but I don’t see why it couldn’t be made to work given some effort.

@cesarandreu

This makes it so hotloading will work when using Relay. It won't reload your fragments and re-fetch data... But it enables you to at least iterate on components, so I'd view it as an improvement.

I’m rather confused. Babel plugin should find the inner component and force its re-rendering on changes regardless of whether it is wrapped in a Relay container or anything else. Is this not the case? Would you like to investigate why?

from babel-plugin-react-transform.