Giter VIP home page Giter VIP logo

Comments (3)

 avatar commented on May 14, 2024

My πŸ‘Ž on this is that it adds more code to the boilerplate that isn't strictly needed which you might say contradicts the following snippet from the readme:

This boilerplate is purposefully simple to show the minimal configuration for React Hot Loader.

from react-hot-boilerplate.

adam-beck avatar adam-beck commented on May 14, 2024

@danmartinez101 but don't you lose out on the "syntax error overlay" that @gaearon mentioned? It's very useful and having at least an example of using the middleware would be beneficial IMO.

from react-hot-boilerplate.

 avatar commented on May 14, 2024

The overlay is a very nice feature indeed! I skimmed over that part. Sorry for that :/
Thank you for calling me out on this :)

While my comment was wrong, the spirit of it still holds true: I think it would be best to remove as much code from this boilerplate as is possible. I (wrongly) assumed that "use webpack-dev-middleware" meant that more code would need to be added to the project.

I've since submitted a pull request that results in a net reduction in lines of code and also brings the overlay into the picture. You can check it out here: #81

from react-hot-boilerplate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.