Giter VIP home page Giter VIP logo

Comments (4)

carlesnunez avatar carlesnunez commented on May 23, 2024

Ok I recently discovered something. It seems that adding e.stopPropagation to the button handler avoids the native event from being executed which lead me to the point in which it seem that the bridge between synthetic event bubbling to native events is being blocked by the component rendering execution.

Adding e.stopPropagation solves the problem but I don't like to have this side effects.

from react-hot-loader.

carlesnunez avatar carlesnunez commented on May 23, 2024

Any clue on whats going on? @gaearon ๐Ÿ™

Thanks in advance.

from react-hot-loader.

theKashey avatar theKashey commented on May 23, 2024

Neither @gaearon nor @theKashey are actively looking at React-Hot-Loader anymore. It was deprecated a year ago and nowadays you are expected to use "natively supported" Fast Refresh, not "hacky" RHL

But there are some clues. I am not sure that your problem is related to RHL, but there are few issues with "arrow methods" as well as with life cycle ones, for example you might not be able to remove this handler, as this.handleOutsideClick can point to another "version" of it.

As well as it can be added before "control" will be returned to the browser (pretty sure it's the case), and this has nothing with RHL.


The fix is simple - use useEffect, as it will be executed "later". Note that componentDidMount is equal to useLayoutEffect, and you can run into the problem I've described above.

If you are not able to convert this one to a functional component or defer this logic to another component - try wrapping addEventListener with some cancelable setTimeout.

In any case, converting class-based one to the functional-based one will:

  • fix the problem (useEffect)
  • fix the problem (connect addEventListener and removeEventListener, preventing the first issue I've described above)
  • fix the problem (FastRefresh)

from react-hot-loader.

carlesnunez avatar carlesnunez commented on May 23, 2024

Thank you for taking your time on replying me. I'll definetivelly try it!

from react-hot-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.