Comments (4)
Ok I recently discovered something. It seems that adding e.stopPropagation to the button handler avoids the native event from being executed which lead me to the point in which it seem that the bridge between synthetic event bubbling to native events is being blocked by the component rendering execution.
Adding e.stopPropagation solves the problem but I don't like to have this side effects.
from react-hot-loader.
Any clue on whats going on? @gaearon ๐
Thanks in advance.
from react-hot-loader.
Neither @gaearon nor @theKashey are actively looking at React-Hot-Loader anymore. It was deprecated a year ago and nowadays you are expected to use "natively supported" Fast Refresh, not "hacky" RHL
But there are some clues. I am not sure that your problem is related to RHL, but there are few issues with "arrow methods" as well as with life cycle ones, for example you might not be able to remove this handler, as this.handleOutsideClick
can point to another "version" of it.
As well as it can be added before "control" will be returned to the browser (pretty sure it's the case), and this has nothing with RHL.
The fix is simple - use useEffect
, as it will be executed "later". Note that componentDidMount
is equal to useLayoutEffect
, and you can run into the problem I've described above.
If you are not able to convert this one to a functional component or defer this logic to another component - try wrapping addEventListener
with some cancelable setTimeout
.
In any case, converting class-based one to the functional-based one will:
- fix the problem (useEffect)
- fix the problem (connect addEventListener and removeEventListener, preventing the first issue I've described above)
- fix the problem (FastRefresh)
from react-hot-loader.
Thank you for taking your time on replying me. I'll definetivelly try it!
from react-hot-loader.
Related Issues (20)
- React.useEffect's callback will be called when the page is updated HOT 2
- Hot reloading tested in different ways and is not working properly HOT 1
- Sometimes hot() is needed not only for the root component HOT 2
- Hot-Reload fails with โUnexpected token '['. Expected opening '{' at the start of a class body.โ HOT 1
- Warning: The final argument passed to useEffect changed size between renders.
- Could not resolve dependency HOT 12
- Not working with react-router-config: Uncaught ReferenceError: module is not defined HOT 9
- Reload Full Page instead of Refresh? HOT 1
- Attempted import error: 'AppContainer' is not exported from 'react-hot-loader'. HOT 1
- when props include "this"
- How to deal with multiple entries
- in sub project cannot replace in time
- React-hot-loader compatibility with React 16.14.0 HOT 1
- React 18 upgrade HOT 5
- Yarn 3 PNP not compatible
- Regular Expression Denial of Service (ReDoS) HOT 3
- hmr no work in React.PureComponent HOT 2
- Analysis: 98% of dependency updates in this repository can be merged.
- React-Hot-Loader: misconfiguration detected, using production version in non-production environment.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-hot-loader.