Giter VIP home page Giter VIP logo

Comments (2)

Galaxies99 avatar Galaxies99 commented on June 24, 2024 1

Hi, thank you for your interest in our re-implementation of the DeepHDR!

We are not the original authors of the paper, and thus we only follow the paper to implement the method in pytorch.

I think the tone-mapping function can be added in the model, if the downstream applications is fixed. Otherwise I think it might be better to let the users to choose the type of tone-mapping methods according to their downstream applications.

Also, I think the train code is saving the checkpoints (see L141-142 of train.py). I would suggest you to check that whether configs.checkpoint_dir is correctly set, since it might not exist especially in CoLab environment.

from deephdr-pytorch.

orzanai avatar orzanai commented on June 24, 2024

Hi, thank you for your interest in our re-implementation of the DeepHDR!

We are not the original authors of the paper, and thus we only follow the paper to implement the method in pytorch.

I think the tone-mapping function can be added in the model, if the downstream applications is fixed. Otherwise I think it might be better to let the users to choose the type of tone-mapping methods according to their downstream applications.

Also, I think the train code is saving the checkpoints (see L141-142 of train.py). I would suggest you to check that whether configs.checkpoint_dir is correctly set, since it might not exist especially in CoLab environment.

Thank you so much for your fast answer, much appreciated!

from deephdr-pytorch.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.