Grafana: changed query field about container-node_exporter-textfiles HOT 8 OPEN

That works for me. I’ll work that into the PR.

This does mean that the chart json would move into this repo though. I don’t know of a way to collaborate on a chart that’s been uploaded to grafana. Is that ok?

from container-node_exporter-textfiles.

@tdorsey Thanks for raising the issue!

I have gone ahead and updated the Dockerfile to use debian:buster-slim and updated the smartmon.sh script.

Could you please verify that continue to get the smartmon_temperature_celsius_raw_value metrics with the latest image v1.1.0 (quay image is already built, Docker Hub still needs a few more minutes).

A potential fix could be to use the and operator (in my case it seems to work as expected):

avg(smartmon_temperature_celsius_raw_value{instance=~"$instance"} and smartmon_airflow_temperature_cel_value) by (instance, disk)

(https://prometheus.io/docs/prometheus/latest/querying/operators/#logical-set-binary-operators)
Would you be up to open a PR changing the affected queries to use and in them as shown in the example?

from container-node_exporter-textfiles.

Yeah, that's no problem, although I can't guarantee an ETA.

Keeping in mind that I know next to nothing about prometheus vectors, do you know why an or instead of and fails to return data? I'd assume that if smartmon ever returned both airflow* and raw* that the graph would have duplicated data, but using an or operator fails to return either set...

from container-node_exporter-textfiles.

I have looked into the whole thing a bit further, seems that different HDDs might report a different set of SMART values.
In my K8S cluster with the v1.1.0 image (and before that) I'm getting both metrics (smartmon_temperature_celsius_raw_* and smartmon_airflow_temperature_*).

What do you think about adding keeping the Disk Temperature and adding a new panel next to it with the airflow temps?
So like this Smartmon Textfile-1569782184745.txt
(I had to rename the file to end with .txt because GitHub doesn't allow .json uploads)
This isn't a perfect solution, as one graph might be empty depending on the SMART values exposed by the disks, though at least from my perspective it would be a good compromise for the dashboard.

from container-node_exporter-textfiles.

Yeah, there isn't really a good way. Moving the chart in the repo is fine.

from container-node_exporter-textfiles.

@tdorsey ping, any updates on this issue?

from container-node_exporter-textfiles.

@galexrt Sorry for the delay on this. The version of grafana I'm working with has changed json schema formats significantly in the interim, but this version is working for me. Let me know if you see issues

from container-node_exporter-textfiles.

@tdorsey As written in the PR, just update the existing dashboard json file. Please add the Grafana version requirement to the README Grafana section.

from container-node_exporter-textfiles.