Incorrect child window height in "Invalid File!" popup about imgui-addons HOT 4 CLOSED

The PR is open.

And as a complete unrelated side note, consider removing the SetNextWindowPos and SetNextWindowSize in showFileDialog(), because in my use case with Multi-Viewport feature enabled in IMGUI, this will allow for the window size and position being persisted between dialog opening sessions and application sessions since it is persisted in imgui.ini instead of being fixed each time the dialog is open.

from imgui-addons.

Thanks for the PR. It's merged. I'll look into the function calls you mentioned when I get back to it. Happy coding.

from imgui-addons.

Hi, nice find. I'm currently busy due to transitioning my workspace to linux so don't really have time to fix this. You can open up a PR maybe?

I think the scrollbar is appearing because of

float cw_height = std::min<float>(4.0f * frame_height, cw_content_height);

Currently it's being set to a maximum of 4 * frame_height. In case of the number of extension being 4 or less, the child window height is being set the same as the content height. I think the scrollbars appear when the size of the content is the same or exceeds the window height. You could try adding a small factor to the window height to always make it bigger than the content incase the content has less than 4 extensions by doing

float cw_height = std::min<float>(4.0f * frame_height, cw_content_height) + delta // delta = a small amount like frame_height/2;

If that doesn't work, you can always try passing the no scrollbar option to the BeginChild function when you have 4 or less extesnsions.

from imgui-addons.

I will be opening up a PR this day or two, using your advice and tweak it a bit if it doesn't work.
Then we will see how it goes by the time the PR is open.

from imgui-addons.