Error from `importjs#ImportJSImport` command about import-js HOT 3 CLOSED

On line 71 in import-js/ruby/import-js/importer.rb there are some method calls that are split onto separate lines. I assume my version of Ruby doesn't like that syntax - when I moved those methods all onto one line the error went away.

Edit: Support for newlines after method calls was added in Ruby 1.9 so my Vim installation must be using an old version of Ruby.

@trotzig Moving the placement of the dot makes this backwards compatible with old Ruby versions, like so:

70 string.
71 gsub(/::/, '/').
72 gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2').
73 gsub(/([a-z\d])([A-Z])/, '\1_\2').
74 tr('-', '_').
75 downcase

However, this Ruby styleguide recommends keeping the dot as the prefix rather than placing it at the end like this. I agree that the 1.9 syntax is more readable.

Options:

• Update the README to expect users to have Ruby 1.9+ when using this plugin.
• Move to the old syntax and support older versions of Ruby.

I'll submit pull requests for each option.

from import-js.

It looks like you can use the commands :echo has('ruby') and :ruby puts RUBY_VERSION to inspect whether Vim has Ruby set up and what version it's running.1

Mine is using '1.8.7' which is probably just the system default. I'm going to try and set it to one of the more recent versions.

from import-js.

Closed by 0cd733e

from import-js.