generic logger about go-marathon HOT 8 CLOSED

BTW, how config.LogOutput is actually used?

from go-marathon.

I assume it's not used any more. All logging is done with glog currently which is a bit inflexible.

from go-marathon.

Ok, I've removed its assignment from examples code in #79

from go-marathon.

@x-cray, it was left over from the previous logging code ... although this issue is supposed act as a reminder to replace that as well :-) ..

from go-marathon.

We are using a customized glog version. As soon as we include another package that imports the "original" glog version, we get a panic:

panic:
xxx.test flag redefined: log_dir

... which makes sense. Not sure how to solve this, yet.

from go-marathon.

Maybe this helps: https://github.com/golang/glog/blob/master/glog.go#L914

from go-marathon.

@mattes I think the best solution would be to not to use glog directly, rather injecting logger to the library through config.
I know that it was done in grpc-go for example: https://github.com/grpc/grpc-go/tree/master/grpclog
We can do the same, though maybe there are some better practices?

from go-marathon.

ref: #103

from go-marathon.