Comments (6)
Overall, it looks pretty good, but a couple preliminary notes:
- The turning code should probably be using a P controller
- It should also deal with turning in the shortest direction and what happens when you hit the point where the angles range
from gm0.
I am not a very advanced programmer, is it okay to reference using a PID controller and include code that scales the speed according to the percentage of the turn completed?
from gm0.
and include code that scales the speed according to the percentage of the turn completed?
This is pretty similar to what a P controller is :). A P controller sets the speed to(target - setpoint) * kP
, where kP is a tuned constant, so that you slow down as you approach the target so you do not overshoot. Mentioning full-on PID control would be smart, but I think a P controller is sufficient for this example.
from gm0.
I have worked more on it. What changes would you still like to see?
from gm0.
Most of my suggestions would involve relatively small wording changes. It would be easier to deal with those if you opened a pull request for this, as I could use GitHub review functionality.
from gm0.
from gm0.
Related Issues (20)
- In SDK version 8.1 and later, iterative `OpMode`s have better behavior
- Possible Incorrect Information in the Software Glossary
- Add section for gamepad rumble / LED control
- Driver Hub
- Multiple issues with Finite State Machine page HOT 1
- FSM Useful Implementation Syntax Error
- Mecanum sample code should bind resetYaw() to a button
- Add Laser Cutting Section
- Add images to materials guide
- Revamp Kit and Hardware guide
- Change Github Actions to use Node.js v16 HOT 2
- Add support for Japanese Translation HOT 3
- Arm Kinematics/Feedforward
- Update to the Software/Tutorials/Computer Vision page (SDK 8.2+)
- Add images/CAD to motion mounting page
- Add a translation version of Chinese Translations HOT 4
- Add Purchasing Advice to Belt Page HOT 1
- Add COTS Dead Wheels to Dead Wheels Page HOT 1
- Add a Shaft Retention Page
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gm0.