Giter VIP home page Giter VIP logo

Comments (6)

abidingabi avatar abidingabi commented on September 16, 2024

Overall, it looks pretty good, but a couple preliminary notes:

  • The turning code should probably be using a P controller
  • It should also deal with turning in the shortest direction and what happens when you hit the point where the angles range

from gm0.

Krabbenhoft avatar Krabbenhoft commented on September 16, 2024

I am not a very advanced programmer, is it okay to reference using a PID controller and include code that scales the speed according to the percentage of the turn completed?

from gm0.

abidingabi avatar abidingabi commented on September 16, 2024

and include code that scales the speed according to the percentage of the turn completed?
This is pretty similar to what a P controller is :). A P controller sets the speed to (target - setpoint) * kP, where kP is a tuned constant, so that you slow down as you approach the target so you do not overshoot. Mentioning full-on PID control would be smart, but I think a P controller is sufficient for this example.

from gm0.

Krabbenhoft avatar Krabbenhoft commented on September 16, 2024

I have worked more on it. What changes would you still like to see?

from gm0.

abidingabi avatar abidingabi commented on September 16, 2024

Most of my suggestions would involve relatively small wording changes. It would be easier to deal with those if you opened a pull request for this, as I could use GitHub review functionality.

from gm0.

Krabbenhoft avatar Krabbenhoft commented on September 16, 2024

#421

from gm0.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.