[bug]: form fields validation must be also done in backend about jagratiwebapp HOT 9 OPEN

Hi! Thanks for opening your first issue at JagratiWebApp 🚀 We really appreciate it. 🙌 Someone from our team will get back here soon.

from jagratiwebapp.

Thanks, @engineerscodes for raising this issue. We should definitely validate the form in the backend. But I think a better place to validate the forms is forms.py and not views. Views should only contain the main backend logic.

We are trying to port our forms to Django forms, starting from issue #263, as backend would definitely provide a better form validation.

from jagratiwebapp.

@garg3133 he is mentioning this issue while creating a new user account, I guess so we need a form there too
I would like to work on this

from jagratiwebapp.

look at this line -

before doing this you could do regex, to check if its a valid Email address or Not

from jagratiwebapp.

Yes, your right I did not see the form.py file, you could do def clean and raise an error if it's not a valid email

from jagratiwebapp.

There is already form.py

from jagratiwebapp.

Yeah, I guess I created this form to escape Django's password validation while creating a new user through Admin Portal (you can see this form is only used in accounts/admin.py).

I think we can just create a new form here, and use Django's password validation out-of-the-box and check the email against the Regex pattern in clean_email method.

from jagratiwebapp.

I would like to work on this @garg3133

from jagratiwebapp.

sir I am django developer and currently working on making REST APIs through django and integrate it with react frontend, so I would like to work on this if assigned

from jagratiwebapp.