Comments (13)
I've changed mindthegap to use USE_NEW_CXX instead of dont_use_tr1. could you try to compile it now? (update mindthegap and gatb-core).
I'd like to deprecate dont_use_tr1 because use_new_cxx already exists
from gatb-core.
looks like the CI could compile it just now
from gatb-core.
are you sure you pushed to mindthegap? i dont see any new commit. (right now mindthegap CI works because I temporarily added dont_use_tr1 variable to the cmakelist of mindthegap)
from gatb-core.
yeah, here : https://github.com/GATB/MindTheGap/commits/master
from gatb-core.
oh, this does not appear in the gforge repo, did you commit to the wrong repo :) ?
from gatb-core.
oh yes, I did :) fixed.
from gatb-core.
thx, ok to switch to use_new_cxx. It seems I have to add the -DUSE_NEW_CXX in the gatb-core cmakelist.
By the way, how should we deal with such minor modif ? The politic for tools is to point to a released gatb-core submodule. Should we make a new patched gatb-core release just for this ?
from gatb-core.
Hi guys !
MindTheGap CI does not compile on mac.
To take into account your last modifications, is it necessary to update gatb-core ? Currently I think mindthegap points to gatb-core release v1.2.0, so this is this version of gatb-core that is used in CI.
from gatb-core.
I made mindthegap point to the current master version of gatb-core (and committed it), it did not fix the problem with tr1.
Guillaume, does it compile on your mac ?
from gatb-core.
I pushed a new patch in gatb-core and again made mtg point to it, CI works now.
from gatb-core.
hmm, or not :) it compiles and passes all test, but another error comes (Invalid escape sequence .), dont know what that is.
from gatb-core.
thanks ! I know what it is, I am fixing it !
from gatb-core.
I had added -DUSE_NEW_CXX to MindTheGap CMakefile's. It's odd that you needed to have it defined in gatb-core's CMakefile also, isn't it? Because gatb-core doesn't have any #ifdef USE_NEW_CXX.
I think our politics are to only link to a released version of gatb-core. But since it's a minor modification here , we could pragmatically point to the appropriate commit that we want, until we release a gatb-core update.
from gatb-core.
Related Issues (20)
- Setting install prefix HOT 6
- Depth-first search on a graph HOT 7
- missing parts of HDF5 HOT 3
- Could not find ZLIB HOT 2
- Segmentation fault when creating de Bruijn Graph HOT 1
- please create new release HOT 2
- Memory reservation in dbgh5 HOT 4
- compilation error with new version of AppleClang HOT 6
- problem with <boost/graph/adjacency_list.hpp> HOT 3
- printf messes with type of size_t HOT 1
- segmentation fault with the test code HOT 1
- Kmer size clarification HOT 2
- A different parallelisation granularity in GATB HOT 2
- Please tag release to allow compilation of minia HOT 1
- Help Wanted HOT 1
- Reading BAM files HOT 4
- -DNONCANONICAL doesnt work on osx?
- How to use Model Direct? HOT 1
- Tutorial links for videos and pdf are not responding
- Support for aarch64 / M1 macs? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gatb-core.