[Bug] Memory leaks in DataFrame class, etc. about gradebook-management-system HOT 4 OPEN

The memory leak could be fixed with

std::map<std::string, std::string&> DataFrame::operator[](size_t index) {
    std::map<std::string, std::string&> series;
    for (auto& col : this->data) {
        series[col.first] = col.second.at(index);
    }
    return series;
}

from gradebook-management-system.

Hey!

Are you sure it is a memory leak? As far as I remember, when I designed the DataFrame, I did not allocate any memory (and when I do, it is via smart pointers). I have tried returning a reference instead of a pointer, but it returned some error I don't remember (I have gone through this though: https://stackoverflow.com/questions/1543193/why-cant-i-store-references-in-a-stdmap-in-c). Also, it is a non-owning pointer, meant to be used as a reference.

Did you try running it with Valgrind and see if it reports anything?

I will address some of these issues and fix them when I get some time!

from gradebook-management-system.

std::endl probably should be \n

The reason I used std::endl instead of \n was because it flushes the output buffer, while \n does not. (https://www.geeksforgeeks.org/endl-vs-n-in-cpp/).

from gradebook-management-system.

I really need to get into Valgrind testing this and I haven't so far yet. Fair enough for using endl for that. Just some thoughts I had. Just did some objective debugging on this looking for small things that could cause issues. My big problem is with the operator[].. just needs more debugging and testing.

Do the sizeRows and sizeCols seem inconsistent?

I think the code overall is pretty good.

from gradebook-management-system.