Clean Up Language Files about ce-phoenix HOT 8 CLOSED

I'm in process of cleaning up english.php... What a load of useless stuff is in there!!!!
I found some strings used only inside classes. Is is a good idea to load those strings from inside the class instead of the page that uses the class?

from ce-phoenix.

When you say "classes" do you mean "modules" ?

from ce-phoenix.

No, I mean classes, ie. define('JS_ERROR_NO_PAYMENT_MODULE_SELECTED', '* Please select a payment method for your order.\n');
This one is used only in payment.php class

from ce-phoenix.

As an example, that one would need to be available in checkout_payment.
You do what you think is correct, and test it. If it all works, push it.

from ce-phoenix.

Do you know what's the use of JQUERY_DATEPICKER_I18N_CODE?
Seems like it's not implemented

from ce-phoenix.

english.php done. Moved a lot of text to their corresponding files and removed 38 orphan strings. I'm still in doubt JQUERY_DATEPICKER_I18N_CODE but I'm pretty sure it is not curently in use.

Will test everything and commit changes.

from ce-phoenix.

@Piernas
Were you able to submit those changes? I was going to tackle the orphaned strings, but didn't want to do double work

from ce-phoenix.

@newburns here you have it, but it's probably outdated as some lanuage files has changed since then.
212282a

from ce-phoenix.