Giter VIP home page Giter VIP logo

Comments (7)

gcamp avatar gcamp commented on July 28, 2024

Just looked into this and the problem is more complicated then it seems.

In the first call, the GCDiscreetNotificationView hide itself to change the value in the background. In the second call, the notification view thinks it's hided so it changes the value directly, but then the callback of the animation is called and the first value is changed again.

I don't think there's a way to change the context of an animation while it's in action... So I don't know how to fix this except with a complete rewrite.

Any idea?

from gcdiscreetnotificationview.

dlinsin avatar dlinsin commented on July 28, 2024

I agree, I guess it's not possible to change the context on a running animation. I think the bug has something to do with the method

- (void) setShowActivity:(BOOL) activity

since

- (void) animationDidStop:(NSString *)animationID finished:(BOOL) finished context:(void *) context

in my case doesn't change the activity indicator, it only calls stop.

However, I'm afraid I'm not fully understanding your code in order to help you out.

from gcdiscreetnotificationview.

gcamp avatar gcamp commented on July 28, 2024

Just made some changes that should fix the problem. I'm not closing the issue because this type of bug is not easy to reproduce. Still, I think it's fixed.

from gcdiscreetnotificationview.

dlinsin avatar dlinsin commented on July 28, 2024

Thanks, I'll pull the changes and check it out.

from gcdiscreetnotificationview.

dlinsin avatar dlinsin commented on July 28, 2024

Unfortunately, it doesn't solve the issue...still the same behaviour

from gcdiscreetnotificationview.

gcamp avatar gcamp commented on July 28, 2024

Can you send me a snipet or the viewcontroller where you use the notification view? I'm not able to reproduce the issue…
You can sent it via DM if you want.

from gcdiscreetnotificationview.

dlinsin avatar dlinsin commented on July 28, 2024

With your latest changes this works perfectly! Thanks a lot!

from gcdiscreetnotificationview.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.