Giter VIP home page Giter VIP logo

Comments (1)

kylegoetz avatar kylegoetz commented on June 20, 2024

The issue is that Object.keys does not guarantee it's returning a non-empty array. For example,

lens.props(...Object.keys({})) would be lens.props() which makes no sense.

Another issue is that Object.keys does not guarantee order. So you can't even be sure that your arguments are being passed in in the correct order.

One implementation of Object.keys({foo:'',bar:''}) might return ['foo','bar'] while another might return ['bar','foo']. So even if it works for you right now, there is no guarantee that it will continue to work, or will even work with another JavaScript implementation in another browser or a different version of Node, because the ECMA spec does not require Object.keys to return keys in any specific order.

So I'm not even sure you're right when you say your code is "correct."

from monocle-ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.