Comments (1)
The issue is that Object.keys
does not guarantee it's returning a non-empty array. For example,
lens.props(...Object.keys({}))
would be lens.props()
which makes no sense.
Another issue is that Object.keys
does not guarantee order. So you can't even be sure that your arguments are being passed in in the correct order.
One implementation of Object.keys({foo:'',bar:''})
might return ['foo','bar']
while another might return ['bar','foo']
. So even if it works for you right now, there is no guarantee that it will continue to work, or will even work with another JavaScript implementation in another browser or a different version of Node, because the ECMA spec does not require Object.keys
to return keys in any specific order.
So I'm not even sure you're right when you say your code is "correct."
from monocle-ts.
Related Issues (20)
- Is dissoc possible? HOT 2
- Are the experimental features safe to use in production HOT 1
- Lens set HOT 1
- iso.iso constructor is not equivalent to iso class constructor
- optional: prop for partial keys HOT 3
- Customize Monocle policy regarding missing interposed nodes?
- `Lens#composeAt` method?
- Tree structure HOT 1
- No fromProp method in docs. HOT 1
- fromTraversable(array) - array is deprecated
- How-to: select optional props from record. HOT 1
- learnings resources section
- insertAt & renameAt
- missing dependencies? HOT 1
- Lens.fromPath with array HOT 1
- Optic implemented using Kliesli Arrows HOT 1
- Question: lens to get the selected element form a dictionary HOT 1
- Question: Help with pipe syntax
- Is there any future for monocle-ts? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from monocle-ts.