Giter VIP home page Giter VIP logo

Comments (13)

mharjac avatar mharjac commented on May 20, 2024 1

oh, I'll update the README, can I add your name to it?

Yeah, you have my permission :)

from termshark.

pocc avatar pocc commented on May 20, 2024

Cheers @mharjac! Thanks for your work on this.

from termshark.

gcla avatar gcla commented on May 20, 2024

I'm new to snap and just tried it out - thanks @mharjac :-)

Just to be sure - I think it's the case that snap doesn't yet support filesystem capabilities, is that your understanding too? i.e. I was able to run the snap termshark like this

$ sudo termshark -i eth0

but not as an unprivileged user. Turned up this link by googling: https://forum.snapcraft.io/t/wireshark-and-setcap/9629

I'm on Ubuntu 18.10 at the moment.

One other very minor thing, and this is my fault - when it runs, it displays v<localbuild> at the top. I should've built the version in from the beginning :-/ If it's an easy thing to rebuild, you can get the current version in by compiling like this

$ go install -ldflags="-X github.com/gcla/termshark.Version=1.0.0" ./... 

But not a big deal! Thanks for the work.

from termshark.

gcla avatar gcla commented on May 20, 2024

oh, I'll update the README, can I add your name to it?

from termshark.

mharjac avatar mharjac commented on May 20, 2024

Just to be sure - I think it's the case that snap doesn't yet support filesystem capabilities, is that your understanding too?

Yes, you're right. Currently it isn't possible to execute it without root privileges.

One other very minor thing, and this is my fault - when it runs, it displays v<localbuild> at the top. I should've built the version in from the beginning :-/ If it's an easy thing to rebuild, you can get the current version in by compiling like this

Don't worry about that, it's just minor visual defect :) I've removed source-tag option from snapcraft.yaml, so from now on your every commit should trigger automatic rebuild and publish it to the edge channel and I would manually promote every stable release to the stable channel.

from termshark.

tkisason avatar tkisason commented on May 20, 2024

awesome! 👍

from termshark.

gcla avatar gcla commented on May 20, 2024

Hi @mharjac - would it be possible for you to update the snap package to v2.0.2? Many thanks!

from termshark.

mharjac avatar mharjac commented on May 20, 2024

Hi @mharjac - would it be possible for you to update the snap package to v2.0.2? Many thanks!

Hey! I've tried to build new snap but it failed with the following errors while building app:

github.com/gcla/tail/tail.go:188:45: cannot use &tail.Tomb (type *"github.com/gcla/tail/vendor/gopkg.in/tomb.v1".Tomb) as type *"github.com/hpcloud/tail/vendor/gopkg.in/tomb.v1".Tomb in argument to tail.watcher.BlockUntilExists

github.com/gcla/tail/tail.go:327:49: cannot use &tail.Tomb (type *"github.com/gcla/tail/vendor/gopkg.in/tomb.v1".Tomb) as type *"github.com/hpcloud/tail/vendor/gopkg.in/tomb.v1".Tomb in argument to tail.watcher.ChangeEvents

from termshark.

gcla avatar gcla commented on May 20, 2024

I think I've messed up the tags... Could you try the following:

export GO111MODULE=on
go install github.com/gcla/termshark/v2/cmd/termshark

Then try ~/go/bin/termshark -v ?

Thanks :)

from termshark.

gcla avatar gcla commented on May 20, 2024

Sorry to pester you @mharjac - any luck with the snap? A couple of redditors were trying to install that way.

from termshark.

mharjac avatar mharjac commented on May 20, 2024

Unfortunately, not. As it seems, snapcraft's go plugin doesn't support go modules so I'm trying to override that.

from termshark.

mharjac avatar mharjac commented on May 20, 2024

Finally... 2.0.2 released in stable channel.

from termshark.

gcla avatar gcla commented on May 20, 2024

Many thanks @mharjac!

from termshark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.