2.0.0: build fails end compile time warnings about geany-plugins HOT 10 OPEN

I've just created #1315, #1316, and #1317 to eliminate some of the warnings in my plugins.

from geany-plugins.

Well, there's also the competing #1238 that tries to support about everything. I haven't checked if it works, I personally would prefer supporting only a single version since nobody will be able to test all the versions (especially when the plugin is unmaintained).

from geany-plugins.

Looks like number of compile time warnings is quite high
Summary stats on bilding with ignore make errors (with -k):

$ rpmbuild -ba geany-plugins.spec --quiet 2>&1 | grep -- \\[-W | sed 's/.*\[//; s/\]//' | sort | uniq -c | sort -nr
    613 -Wdeprecated-declarations
     11 -Wunused-variable
     11 -Wimplicit-function-declaration
      8 -Wunused-result
      7 -Wdiscarded-qualifiers
      6 -Wunused-function
      5 -Wformat=
      1 -Wunused-const-variable=
      1 -Wunused-but-set-variable
      1 -Wincompatible-pointer-types

from geany-plugins.

I'm using gcc 14.x so it shows a bit more like -Wincompatible-pointer-types warnings

Extracted stderr with all warnings and errors geany-plugins.stderr.txt

from geany-plugins.

Build may fail in lua beause I'm using patch which enabled build with lua >= 5.2

--- a/build/geanylua.m4
+++ b/build/geanylua.m4
@@ -14,10 +14,8 @@
         done])

     LUA_VERSION=5.1
-    LUA_VERSION_BOUNDARY=5.2
     GP_CHECK_PLUGIN_DEPS([GeanyLua], [LUA],
-                         [${LUA_PKG_NAME} >= ${LUA_VERSION}
-                          ${LUA_PKG_NAME} < ${LUA_VERSION_BOUNDARY}])
+                         [${LUA_PKG_NAME} >= ${LUA_VERSION}])
     GP_CHECK_PLUGIN_DEPS([GeanyLua], [GMODULE], [gmodule-2.0])
     GP_COMMIT_PLUGIN_STATUS([GeanyLua])

It would be good to update for latest lua because older versions are buggy and longer maintained (there are few CVEs in lua older than 5.4).

from geany-plugins.

GTK deprecations should continue to work on GTK3 which is all Geany and plugins support. So these warnings will likely not go away until a GTK4 port happens, so they should not be allowed fail a build.

For the Geanylua plugin, are you sure your build is using a version of the lua headers/library that is supported by the plugin? Note that geanylua is unmaintained and will not have been updated if type and function names in Lua headers have changed. Unless "somebody" with the time and ability takes the plugin under their wing it won't be updated to newer versions.

The project organiser incompatible pointer just needs an explicit cast @techee (As an aside, I thought incompatible pointers was in GCC 13, not 14)

from geany-plugins.

After disable build projectorganizer and geanylua I was able to build geany-plugins.

For the Geanylua plugin, are you sure your build is using a version of the lua headers/library that is supported by the plugin?

As I wrote I've been trying to build against latest lua 5.4 using --enable-geanylua --with-lua-pkg=lua + patch which I've posted here.

The project organiser incompatible pointer just needs an explicit cast @techee (As an aside, I thought incompatible pointers was in GCC 13, not 14)

gcc 14.x is now even more sensitive on pointer typing.

from geany-plugins.

As I wrote I've been trying to build against latest lua 5.4

Yeah, I didn't see your post until I had hit comment

gcc 14.x is now even more sensitive on pointer typing.

As a C++ programmer I totally approve (he says writing reinterpret_cast) 😁

from geany-plugins.

Unless "somebody" with the time and ability takes the plugin under their wing it won't be updated to newer versions.

This happened in #1235.

from geany-plugins.

This happened in #1235.

It was good of you to update it even if you don't use the plugin. But sadly it seems no real Geanylua users could build and test it in the year since it was created. @frlan maybe it should be merged anyway since the plugin will die otherwise.

from geany-plugins.