Comments (6)
Original comment by Michael Granger (Bitbucket: ged, GitHub: ged).
Thanks for the patch. I'll look it over this weekend.
from ruby-pg.
Original comment by Michael Granger (Bitbucket: ged, GitHub: ged).
Applying the patch as-is breaks the build for me:
../../../../ext/pg.c:2602:39: error: operator '||' has no right operand
../../../../ext/pg.c: In function ‘pgconn_block’:
../../../../ext/pg.c:2608: error: ‘zerotime’ undeclared (first use in this function)
../../../../ext/pg.c:2608: error: (Each undeclared identifier is reported only once
../../../../ext/pg.c:2608: error: for each function it appears in.)
It's likely just a matter of a missing defined()
at line 2602.
I'll fix that and get this applied. Do you have a minimal test case that demonstrates the problem? I can probably figure it out myself, but I'm wondering if it's possible to write a test for it, and thought if you already had something you used, I'd have a headstart.
from ruby-pg.
Original comment by Anonymous.
After running into performance problems I found out that the previous patch that added a small wait (1ms) after each PQisBusy is not a good idea. I have committed the next patch:
https://bitbucket.org/rafalbigaj/ruby-pg/changeset/fc4109b2ddba
which uses Winsock events and rb_w32_wait_events.
The proposed solution is faster about 20-30% on WIN32 than the original code.
from ruby-pg.
Original comment by Rafał Bigaj (Bitbucket: rafalbigaj, GitHub: rafalbigaj).
I have attached the simple script that I uses to test if the connection problem still exist.
During the script is running I release my network connection. On the original code I frequently encounter hangs.
How to write automated test for it?
from ruby-pg.
Original comment by Rafał Bigaj (Bitbucket: rafalbigaj, GitHub: rafalbigaj).
One commit more:
https://bitbucket.org/rafalbigaj/ruby-pg/changeset/2bc78e46c1b6
that fixes memory leaks (forgot to close opened event).
from ruby-pg.
Original comment by Michael Granger (Bitbucket: ged, GitHub: ged).
Fixes #66 Win32 asynchronous queries hang on connection error
from ruby-pg.
Related Issues (20)
- PG::Coder.new(hash) is deprecated HOT 6
- Timezone timestamp decoder behavior mismatch with hash vs. keyword arguments on v1.5.0 HOT 1
- PG 1.5.0 may have broken COPY exports HOT 2
- Seg fault after upgrading to pg v1.5.2 HOT 3
- Saw Rails DB connection pool spike after upgrading from 1.4.6 to 1.5.2 HOT 5
- failed to install pg 1.4.6 on Centos7 with ruby 3.2.0, whereas with ruby 3.1.0 it installs HOT 3
- How to build an old pg on ruby 2.3.1 HOT 1
- Segmentation fault with ruby 2.7.8 and pg 1.5.3 HOT 10
- Segmentation fault HOT 28
- Sonoma: getaddrinfo segmentation fault HOT 2
- Segmentation fault in ruby:3.2.2-alpine3.18 docker image HOT 2
- Wrong binary conversion on x86 (32bit intel) arch causing test failures HOT 4
- Bad IAM Token against Amazon Aurora Postgres: Out of memory error HOT 2
- Attempting to execute a sql file with `\set ...` raises errors HOT 3
- conn.exec writing "INFO" statements to stderr instead of stdout HOT 2
- Segfault on ruby 3.2.2, pg 1.5.4 HOT 2
- Error ruby(39749,0x1e1f05300) malloc: double free for ptr 0x13c6bfa00 HOT 1
- Segmentation fault when connecting to RDS HOT 11
- Broken links in documentation HOT 3
- connection.reset don't check again DNS HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ruby-pg.