Giter VIP home page Giter VIP logo

Comments (5)

josephholsten avatar josephholsten commented on June 30, 2024 1

wow, how did I PR myself? opening against the real repo...

from ansible-role-homebrew.

elliotweiser avatar elliotweiser commented on June 30, 2024

I agree with the reasoning here. The defaults should be empty and the usage should be documented 👍

I think the original PR was closed since @z00m1n's fork was deleted. Will look into addressing this myself.

(EDIT: Unless @z00m1n wants to take another crack at it)

from ansible-role-homebrew.

josephholsten avatar josephholsten commented on June 30, 2024

@elliotweiser @z00m1n anything else we need in this PR?

from ansible-role-homebrew.

elliotweiser avatar elliotweiser commented on June 30, 2024

@josephholsten Just looked at the commit in which you mentioned this issue. I think that was the essence of the original PR i.e. don't install any packages/casks unless the user says otherwise. Go ahead and open the PR and I'll review.

from ansible-role-homebrew.

elliotweiser avatar elliotweiser commented on June 30, 2024

@josephholsten One thing I forgot to mention-- the defaults documented in the README.md will need to be updated as well.

from ansible-role-homebrew.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.