Giter VIP home page Giter VIP logo

Comments (12)

GeertJohan avatar GeertJohan commented on June 17, 2024

Do you mean (*File).Readdirnames() or (*Box).Readdirnames(), as shown in the example?
Is (*File).Readdir() a solution for you?

from go.rice.

 avatar commented on June 17, 2024

(*Box).Readdirnames(), similar to the (*os.File).Readdirnames(). How can I use (*File).Readdir()? f, _ := box.Open("."); fi, _ := f.Readdir(-1)?

from go.rice.

PaulMaddox avatar PaulMaddox commented on June 17, 2024

I think I implemented this already, but made it private.
I think it just needs renaming from (*Box).readDirNames(path string) ([]string, error) to (*Box).Readdirnames(path string) ([]string, error) to expose it as part of the public API.

https://github.com/GeertJohan/go.rice/blob/master/walk.go#L87

from go.rice.

 avatar commented on June 17, 2024

@PaulMaddox
I'd seen it, but the signatures differ. (*os.File).Readdirnames() accepts int. What path am I supposed to pass to this method?

from go.rice.

PaulMaddox avatar PaulMaddox commented on June 17, 2024

If you're just looking to get a list for the root of the box, use "" as the argument.

from go.rice.

 avatar commented on June 17, 2024

@PaulMaddox That will do, I think, assuming the method is public.

from go.rice.

GeertJohan avatar GeertJohan commented on June 17, 2024

Wouldn't it then be better to add Readdirnames(int) on *File instead of *Box ?

from go.rice.

GeertJohan avatar GeertJohan commented on June 17, 2024

That way it can also be used for non-root paths..

from go.rice.

 avatar commented on June 17, 2024

Wouldn't it then be better to add Readdirnames(int) on *File instead of *Box ?

Perhaps. I somewhat dislike the idea of naming the method the same, but changing its signature. If I could call Open(".") (or Open("")) on the box, of course.

from go.rice.

GeertJohan avatar GeertJohan commented on June 17, 2024

Signature I proposed is the same right? (*File).Readdirnames(n int) ([]string, error)

from go.rice.

 avatar commented on June 17, 2024

@GeertJohan
Yes.

from go.rice.

GeertJohan avatar GeertJohan commented on June 17, 2024

Okay. I'd be happy to take a PR for this.

from go.rice.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.