embed-go performance and memory usage about go.rice HOT 9 CLOSED

Wow, that is pretty neat! I'm just wondering: isn't there a package that does the encoding into a string? It feels a bit weird to have that as part of the embedding flow instead of a separate package.

from go.rice.

I couldn't find one. Since strconv.Quote is good for 99% use cases, I guess no one needed to create one.

I've extracted it into a separate package and added some tests, including all the strconv.Quote tests from the standard library: https://github.com/nkovacs/streamquote

I'll update this PR tomorrow.

from go.rice.

That's awesome, thanks!

from go.rice.

I optimized streamquote (got rid of a bunch of small slice allocations), helps a bit with large files (v1 is the previous version from february, v2 is with the optimization)

one big file:

many small files:

from go.rice.

Neat! Do you think this is ready for a PR, or do you still want to change some things?

from go.rice.

I still need to fix filename escaping, if the filename contains {%%}, it might cause problems with fasttemplate.

from go.rice.

Filename escaping has been merged. Thanks!

Do you want to add more code related to this feature, or can we close this issue?

from go.rice.

I just need to fix the issue in my previous comment, I'll have a PR up soon.

from go.rice.

Just merged the PR. Thanks!

from go.rice.