Giter VIP home page Giter VIP logo

Comments (9)

thomaspd avatar thomaspd commented on September 23, 2024 1

from gocamgen.

dustine32 avatar dustine32 commented on September 23, 2024

Thanks! So here's my list right now:

acceptable_evidence_codes = ['EXP', 'IDA', 'IPI', 'IMP', 'IGI', 'IEP', 'HTP', 'HDA', 'HMP', 'HGI', 'HEP', 'ISS']

Any codes I'm missing here?

from gocamgen.

vanaukenk avatar vanaukenk commented on September 23, 2024

We actually also have a handful of manual annotations using these additional codes:

IC
IKR
ISM
ISO
NAS
ND
TAS

If we want to import the whole set of manual annotations, we'll need to include these codes as well.

from gocamgen.

thomaspd avatar thomaspd commented on September 23, 2024

from gocamgen.

goodb avatar goodb commented on September 23, 2024

@thomaspd are the IEA and PAINT annotations not going through the same pipeline as the rest of the annotations? Will they simply skip the GO-CAM collection? If not, why don't we include all of them as part of this experiment?

from gocamgen.

thomaspd avatar thomaspd commented on September 23, 2024

The goal of this phase is specifically to support manual GO curation in Noctua by Alliance curators, so we won't include PAINT and IEAs at this point. We'll figure out whether/how to include them at a later date.

from gocamgen.

dustine32 avatar dustine32 commented on September 23, 2024

@thomaspd Got it! I can easily filter these out:

unwanted_evidence_codes = ['IEA', 'IBA']
unwanted_evi_code_ref_combos = [('IKR', 'PMID:21873635')]

So non-PAINT IKRs will still get translated.

from gocamgen.

ukemi avatar ukemi commented on September 23, 2024

From our perspective it might be easier to filter out rather than in. I think any annotation that is assigned by MGI and doesn't have a ECO:0000266 (ISO) evidence code would be a good first pass. This will allow MGI curators to view and edit the annotations that they have made manually.

from gocamgen.

dustine32 avatar dustine32 commented on September 23, 2024

Now able to filter by rules specific to MOD. Just use --mod option with gen_models_by_gene.py and the filter will use rules coded in [MOD]FilterRule classes.

So far there's WB and MGI along with the default filter:

  • default - Remove IEA, IBA, as well as IKRs originating from PAINT.
  • WB - So far same as default filter.
  • MGI - Only provided_by=MGI lines are valid, also filtering out ISOs along with default filter.

The logic will likely need to be adjusted as rules are refined. We can also think about having these rules coded outside of gocamgen and imported in.

from gocamgen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.