Maintenance + updating to more recent p5.js version about code-package-p5.js HOT 10 CLOSED

Sketch viewer page is complete and online!

from code-package-p5.js.

@Niels-NTG Mega!!

Feedback:

• Would find it better to not open the sketches in a new tab
• If we agree on a singe tab ... then I would add a "back arrow" in the header
• Layout sketch header: as the sketch is running ideally fullscreen ... it would be nice to align far left and right. Doesn't makes sense imo to reflect the column of the main site in the sketch player view.

from code-package-p5.js.

Hey all! Apologies for the slow reply. Getting caught up on web stuff.

@joeyklee could you reach out to your p5.js friends and ask for advice? Which recent version is the best bet for long term support?

• I can ping Lauren, but quite likely the latest version would be the best way to go, or?

Check and fix every sketch, with the http://alpha.editor.p5js.org/generative-design/

• Yep, there's a bunch of issues that I'll need to go through systematically and update.

Thanks for your patience!

@Niels-NTG - bravo on the sketches working directly on the site! 🤙

from code-package-p5.js.

Hi @joeyklee, great! Yes you are right, no need to ping Lauren as we should simply go with the latest one which is currently running in the p5 online editor. Best, B PS. Congrats on the position!

from code-package-p5.js.

@b-g - Cool! Word on the street is that there's also the launch of the v1 of the p5 editor soon ;)

• Thanks! I will ping you via email - I could use some teaching tips!

from code-package-p5.js.

Hi All,
Apologies for the super late action on my side.

I'm adding/updating changes to:

https://github.com/generative-design/Code-Package-p5.js/tree/dev-updates

I'm starting to dive into the updates. A few notes:

firefox blocks CORS for gg-dependency-bundle.js in the p5 editor:

• a work around is to convert all our rawgit ==> http://raw.githack.com/

Uploading files to the p5 editor has changed

UPDATE: turns out, I had privacy badger running on my firefox browser and it was blocking the content from loading. Our sketches should be fine actually!

Clear() function not clearing canvas in p5 0.6.1 ==> p5 0.7.1 should solve this

• it appears the clear() function is not clearing the canvas in p6 0.6.1, when we update to 0.7.1 should be solved

from code-package-p5.js.

Checking Sketches List

I will go down this list 1 by 1 and check if the sketches are working in the current version of the p5 web editor locally before I make a pull request to the p5.js-web-editor on my gg4editor branch (https://github.com/joeyklee/p5.js-web-editor/tree/gg4editor) regarding any updates and changes.

P

• P_1_0_01
• P_1_1_1_01
• P_1_1_2_01
• P_1_2_1_01
• P_1_2_2_01
• P_1_2_3_01
• P_1_2_3_02
• P_1_2_3_03
• P_1_2_3_04
• P_1_2_3_05
• P_2_0_01
• P_2_0_02
• P_2_0_03
• P_2_1_1_01
• P_2_1_1_02
• P_2_1_1_03
• P_2_1_1_04
• P_2_1_2_01
• P_2_1_2_02
• P_2_1_2_03
• P_2_1_2_04
• P_2_1_3_01
• P_2_1_3_02
• P_2_1_3_03
• P_2_1_3_04
• P_2_1_3_05
• P_2_1_4_01
• P_2_1_4_02
• P_2_1_4_03
• P_2_1_4_04
• P_2_1_5_01
• P_2_1_5_02
• P_2_1_5_03
• P_2_1_5_04
• P_2_2_1_01
• P_2_2_1_02
• P_2_2_2_01
• P_2_2_2_02
• P_2_2_3_01
• P_2_2_3_02
• P_2_2_4_01
• P_2_2_4_02
• P_2_2_4_02_class_version
• P_2_2_5_01
• P_2_2_5_02
• P_2_2_6_01
• P_2_2_6_01_class_version
• P_2_2_6_02
• P_2_2_6_03
• P_2_2_6_04
• P_2_2_6_05
• P_2_3_1_01
• P_2_3_1_02
• P_2_3_2_01
• P_2_3_3_01
• P_2_3_3_01_TABLET
• P_2_3_4_01
• P_2_3_5_01_TABLET
• P_2_3_6_01
• P_2_3_6_02
• P_2_3_7_01
• P_2_3_7_02_TABLET
• P_3_0_01
• P_3_1_1_01
• P_3_1_2_01
• P_3_1_2_02
• P_3_1_3_01
• P_3_1_3_02
• P_3_1_3_03
• P_3_1_3_04
• P_3_1_3_05
• P_3_1_4_01
• P_3_1_4_02
• P_3_2_1_01
• P_3_2_1_02
• P_3_2_2_01
• P_3_2_3_01
• P_3_2_4_01
• P_3_2_5_01
• P_3_2_5_02
• P_3_2_5_03
• P_4_0_01
• P_4_1_1_01
• P_4_1_2_01
• P_4_1_2_02
• P_4_2_1_01
• P_4_2_1_02
• P_4_2_2_01
• P_4_2_2_02
• P_4_2_3_01
• P_4_2_3_02
• P_4_2_3_03
• P_4_2_3_04
• P_4_3_1_01
• P_4_3_1_02
• P_4_3_2_01
• P_4_3_3_01
• P_4_3_3_02
• P_4_3_4_01
• P_4_3_4_01_emoji_icon_analyser
• P_4_3_4_02

M

• M_1_1_01
• M_1_2_01
• M_1_3_01
• M_1_3_02
• M_1_3_03
• M_1_4_01
• M_1_5_01
• M_1_5_02
• M_1_5_03
• M_1_5_04
• M_2_1_01
• M_2_2_01
• M_2_3_01
• M_2_3_02
• M_2_5_01
• M_2_5_02
• M_5_1_01
• M_6_1_01
• M_6_1_02
• M_6_1_03
• M_6_2_01
• M_6_2_02

Issues:

The only issues seem to be with the following below. Mostly has to do with loading a ton of data into the browser at once from remote sources. We can either upload directly these files to the p5 web editor server (less preferred), make a note somewhere in the comments that these run better locally, or leave these examples out.

• Loading too many images:

• P_2_3_6_02
• P_4_2_1_01
• P_4_2_1_02

• Supercut media issue:

• P_4_2_3_01
• P_4_2_3_02
• P_4_2_3_03
• P_4_2_3_04

• Emoji

• P_4_3_4_02

@Niels-NTG, @b-g - if you've had a chance to check or don't have any reservations, I would go ahead and merge this dev-updates branch with master, then send a pull request on the gg4editor branch of the p5 web editor so we can integrate the latest.

from code-package-p5.js.

Hi @Niels-NTG, @joeyklee, Many thanks!! I just merged PR #170 ... I think we can close then this issue, or?

Q:

• Can I create a v1.1.0 release
• Add "maintenance release; upgrading to p5.js 0.7.2" to the changelog?
• Joey: Could you deploy the sketches to the online editor?
• Niels: Could you deploy the sketches to the website?

from code-package-p5.js.

@b-g Deploying the sketches to the website is already on my list. I will do it later today. And yes, go ahead with creating the new release tag.

from code-package-p5.js.

Done. Tagged and released v1.1.0. https://github.com/generative-design/Code-Package-p5.js/releases

from code-package-p5.js.