Comments (7)
PaulWessel
commented on June 4, 2024
This might be a simpler example of what @seisman pointed out (those towers near TL BL corners for grids subjected to blending. Darn, can you remind moe of that issue, @seisman ?
from gmt.
joa-quim
commented on June 4, 2024
GenericMappingTools/pygmt#2511 ?
from gmt.
PaulWessel
commented on June 4, 2024
Yes. I will try to debug @Esteban82 example - it is annoying but I spent a lot of time on the grid version already...
from gmt.
PaulWessel
commented on June 4, 2024
This is what I have learned. grdtrack -E creates the profiles, then the cross track machinery computes the angle of the cross profiles to be 180. Then we can sincosd (angle, &s, &c) and get cos = -1 (good) and sin = -1.2246467991473532E-16 (oops). Then, coordinates are computed and instead of getting y = 1 we get 0.99999999999999988 and then it is determined by BCR that the point is outside the grid and we get the default NaN answer.
I think for some reason sincosd fails since it actually calls sincos (angle*D2R) and hence roundoff is likely. So where do we intercept? Make the macro check for angle being exact multiple of 90 and set those returns manually? This is in many places... Suggestions - gotta take a break.
from gmt.
joa-quim
commented on June 4, 2024
Can the BCR be made a bit more tolerant on what is outside? If “sufficiently close accept it”?
Go make the break(s). If necessary, this can stay as a bug (again, our release process is so heavy that it prevents more often releases. I would drop most of the steps in the check list). Only really important bug to fix is that padding effect that makes grdimage crash.
From: Paul Wessel ***@***.***>
Sent: Sunday, December 17, 2023 5:46 PM
To: GenericMappingTools/gmt ***@***.***>
Cc: Joaquim Manuel Freire Luís ***@***.***>; Comment ***@***.***>
Subject: Re: [GenericMappingTools/gmt] Bug with grdtrack and -Ejustification and -C?? (Issue #8194)
This is what I have learned. grdtrack -E creates the profiles, then the cross track machinery computes the angle of the cross profiles to be 180. Then we can sincosd (angle, &s, &c) and get cos = -1 (good) and sin = -1.2246467991473532E-16 (oops). Then, coordinates are computed and instead of getting y = 1 we get 0.99999999999999988 and then it is determined by BCR that the point is outside the grid and we get the default NaN answer.
I think for some reason sincosd fails since it actually calls sincos (angle*D2R) and hence roundoff is likely. So where do we intercept? Make the macro check for angle being exact multiple of 90 and set those returns manually? This is in many places... Suggestions - gotta take a break.
—
Reply to this email directly, view it on GitHub<#8194 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAEDF2N2HO4T2LOUO55KXQ3YJ4VU3AVCNFSM6AAAAABAWXO2GOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGIZTIMZSHE>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
from gmt.
joa-quim
commented on June 4, 2024
Ah, and I have another dinner tonight.
From: Paul Wessel ***@***.***>
Sent: Sunday, December 17, 2023 5:46 PM
To: GenericMappingTools/gmt ***@***.***>
Cc: Joaquim Manuel Freire Luís ***@***.***>; Comment ***@***.***>
Subject: Re: [GenericMappingTools/gmt] Bug with grdtrack and -Ejustification and -C?? (Issue #8194)
This is what I have learned. grdtrack -E creates the profiles, then the cross track machinery computes the angle of the cross profiles to be 180. Then we can sincosd (angle, &s, &c) and get cos = -1 (good) and sin = -1.2246467991473532E-16 (oops). Then, coordinates are computed and instead of getting y = 1 we get 0.99999999999999988 and then it is determined by BCR that the point is outside the grid and we get the default NaN answer.
I think for some reason sincosd fails since it actually calls sincos (angle*D2R) and hence roundoff is likely. So where do we intercept? Make the macro check for angle being exact multiple of 90 and set those returns manually? This is in many places... Suggestions - gotta take a break.
—
Reply to this email directly, view it on GitHub<#8194 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAEDF2N2HO4T2LOUO55KXQ3YJ4VU3AVCNFSM6AAAAABAWXO2GOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGIZTIMZSHE>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
from gmt.
PaulWessel
commented on June 4, 2024
Lamely, this fixes the issue
angle = 90.0 - az_cross - deviation; /* The direction */
sincosd (angle, &sa, &ca); /* Trig on the direction */
i_angle = rint (angle);
if (i_angle == 0 || i_angle == 360) sa = 0.0, ca = 1.0;
else if (i_angle == 90) sa = 1.0, ca = 0.0;
else if (i_angle == 180 || i_angle == -180) sa = 0.0, ca = -1.0;
else if (i_angle == 270 || i_angle == -90) sa = -1.0, ca = 0.0;
from gmt.
Related Issues (20)
- Do not raise "Unrecognized option -x" error if GMT is not compiled with OpenMP/GThreads support? HOT 1
- Ability topping NaN nodes/pixels in grdview with the NaN color HOT 11
- legend: Understand behavior (and difference) of "-C" and "-F+c" HOT 3
- gmt info outcome change with the seconds float point precision HOT 1
- ps-insar deformation mapping using xyz2grd HOT 3
- Link Checker Report on 2024-01-21 HOT 1
- Let Movie create the master frame even if it has the -A parameter HOT 4
- Get last frame (-Ml) when a title sequence is used (-E) in movie HOT 1
- Modifier +e detected but not a valid modifier! - ignored in gmt movie -A+e? HOT 1
- Warning messagge with text via gmt events -Et HOT 5
- Link Checker Report on 2024-01-28
- grdmask with region '-Rg' not recognising longitudes more than 180 HOT 1
- Colorbar: Size of side triangles affects size of NaN box HOT 4
- test/inset/inset-l2s.sh fails
- test/grdcut/vert_cube_cuts.sh fails in macOS/Windows CI HOT 1
- Link Checker Report on 2024-02-04 HOT 1
- Specifying nearneighbor -S, unit not understood? HOT 12
- grdinterpolate generates one layer too much when reading the cube.nc test file
- Link Checker Report on 2024-02-11
- False "Option -XXXX given more than once" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gmt.