Move all long2short (l2s) tests into a separate test directory? about gmt HOT 8 CLOSED

Hmm, all tests are in their own directory with that module name. Why making it different for the ``*.-l2s.sh` tests? I prefer to have them where they are.

from gmt.

The main reason is, these tests work only when USE_COMMON_LONG_OPTIONS and USE_MODULE_LONG_OPTIONS are defined. When they're not defined, these tests should be excluded. However, the current layout (e.g., having psbasemap-l2s.sh in the psbasemap directory) makes it difficult to exclude these directory. Instead, if all l2s tests are located in the test/long2short directory, we just need to exclude the whole test/long2short directory.

from gmt.

OK, but probably what we should do is to make the USE_COMMON_LONG_OPTIONS and USE_MODULE_LONG_OPTIONS the default now. The work is mostly done and does not interfere with the rest. What is needed is to document them (big task).

from gmt.

I we can close this now, I think.

from gmt.

I still prefer to move all l2s tests into a separate test directory, since these tests test the codes in gmt/src/longopt rather than the functionality of individual modules.

from gmt.

In fact, even the fact that the longopt is currently in a bunch of separate headers was discussed at the beginning of this work and the idea was to revise that decision at the end. For example I would rather have each of those .h inserted directly inside the corresponding C code. Anyway, I see no advantage in joining all the l2s tests in a single directory as that makes needlessly harder to find a specific test as comparing to finding it in the directory where all other tests of that module reside.

from gmt.

In fact, even the fact that the longopt is currently in a bunch of separate headers was discussed at the beginning of this work and the idea was to revise that decision at the end. For example I would rather have each of those .h inserted directly inside the corresponding C code.

Makes sense to me. Closing.

from gmt.

Perfect thanks, then one of these days I'll start the .h integration move but we'll have to take care to leave room for the missing supplements longoptions.

from gmt.