Comments (6)
MechJeb 2.9.2.0 added support for Multi-Node maneuvers and deleted the MakeNode()
method which my code wants to call.
Modifications need to be made to all operations; see MuMech/MechJeb2@44ccd89.
from krpc.mechjeb.
This modification causes an error for MechJeb < 2.9.2.0, because now the code tries to call MakeNodes() instead of MakeNode(). Just a suggestion but some backward compatibility would be great.
from krpc.mechjeb.
@EnJiang Thank you for your suggestion. Sometimes it's difficult to keep things backward-compatible, especially in "pre-release" versions (kRPC.MechJeb API is not yet finalized, though it's coming close to v1.0) and it would be too much work to keep all things backward compatible, if not impossible (see commit 95603ab).
When I fixed this issue, I thought that backward compatibility is important mainly for client code, so I kept MakeNode()
and marked it as deprecated. Why do you think that I should consider backward compatibility for MechJeb versions? Is there something that prevents you from updating MechJeb to the newer version?
from krpc.mechjeb.
No. In my case I just downgraded kRPC.MechJeb. It's just it took me some time to google and figure out why I can't make a node and it's a little bit frustrating. If backward compatibility is not economical to do, maybe some clearer indications telling the user maneuver planner won't work perfectly for this version MechJeb would also be good.
All of these are pure optional : )
BTW, I've been wanting a programmatic way of MechJeb manipulating for a long time, your work is so great absolutely love it!
from krpc.mechjeb.
@EnJiang If I may ask, why did you rather downgrade kRPC.MechJeb than upgrade the MechJeb2 itself?
By the way, on the Releases page, there is a compatible kRPC and MechJeb2 version for recent releases. Do you think I should mention it somewhere else as well or write other details?
from krpc.mechjeb.
@Genhis I guess it was just a bit handy because I had kRPC.MechJeb repo opened. I think I'll upgrade all of them to the latest version now.
By the way, on the Releases page, there is a compatible kRPC and MechJeb2 version for recent releases. Do you think I should mention it somewhere else as well or write other details?
Thank you! I will follow that.
from krpc.mechjeb.
Related Issues (20)
- Exception raised in server when creating ascent autopilot object HOT 2
- C-nano client #include uses krpc_cnano directory instead of krpc HOT 4
- C-nano client has an incorrect extension
- MJServiceException Error when trying randezvous script HOT 1
- Attempting to set SmartASS surface vel only sets yaw HOT 1
- Mechjeb2 class changed HOT 2
- AirplaneAutopilot class issue HOT 10
- Unable to create a transfer HOT 1
- autostage_limit attribute in staging controller is not read/writable HOT 2
- KRPC fails to load with KRPC.MechJeb because KRPC.Utils.Tuple no longer exists HOT 2
- AssertionError on Connection HOT 2
- Transform public API into window-oriented approach (plans for 1.0)
- Update Python class docs to use snake_case instead of PascalCase HOT 2
- Python API: connection stream not working? HOT 6
- Add a service json file HOT 1
- Enforce coding convetions through .editorconfig file for Visual Studio HOT 2
- Update the C-nano interface to work with the current kRPC/Mechjeb version HOT 6
- AscentAutopilot launch to rendezvous can not run HOT 2
- Unable to use any procedure of maneuver_planner HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from krpc.mechjeb.