Giter VIP home page Giter VIP logo

Comments (4)

LukaszH77 avatar LukaszH77 commented on July 19, 2024 1

I like the option with confirmation better, but I think for some people that could be annoying

Maybe you can add an option to switch it off?

from tuba.

GeopJr avatar GeopJr commented on July 19, 2024

I'm not super-fond of this to be honest due to the way media-uploading works.

When you attach a file, it first gets uploaded to the server which returns an id that we later attach to the object we send when "Post" is clicked. I wasn't super-fond of Ctrl+V for the same reason but at least the user is somewhat aware by being on the Media page of the composer.

That means that if you accidentally press ctrl + v with sensitive media in your clipboard, they will be uploaded to your instance which has privacy issues. At the same time though, you are supposed to trust your instance somewhat and they do get cleaned-up after some time automatically.

However, when the new composer mockups drop, there probably won't be a "pages" system anyway. The solutions I propose are:

  • A dialog confirming the paste on Ctrl + V
  • Assume instances and their sysadmins do not lookup or keep the discarded media forever

What do you think?

edit:
Keeping the media in memory and uploading only on post is not appropriate either btw, Media uploading can easily fail even though we already keep track of the instance limits (on size and media types) for two reasons:

  1. rate limits
  2. random Mastodon media processing errors like "422 Video has no video stream"

+ if the files are big, the user will have to wait for them to be uploaded on post which might seem like Tuba has frozen

from tuba.

bragefuglseth avatar bragefuglseth commented on July 19, 2024

Maybe you can add an option to switch it off?

Obligatory link to Choosing our Preferences

from tuba.

jmaris avatar jmaris commented on July 19, 2024

I do worry that creating a preference for this would be overkill. I'm not sure it's guideline compliant, but perhaps a confirmation dialogue with the yes option focussed by default. That way people can CTRL+V then ENTER to proceed.

from tuba.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.