Giter VIP home page Giter VIP logo

Comments (7)

GeopJr avatar GeopJr commented on July 2, 2024

That's weird :/ even when the style is set to flat (which is not on narrow mode (it's raised)) it should have some undershoot shadow. I'll try to reproduce it

from tuba.

bertob avatar bertob commented on July 2, 2024

For me it's pretty easy to reproduce on the Home view: The shadows disappear when I scroll, and re-appear when I resize the window.

from tuba.

GeopJr avatar GeopJr commented on July 2, 2024

I can't reproduce it neither on host or flatpak. Could have been a listview issue or (assuming you are using the flatpak) an outdated runtime? Could you give the main branch another try and checking if there're any runtime updates available?

from tuba.

bragefuglseth avatar bragefuglseth commented on July 2, 2024

I'm on the official 0.5.0 Flatpak, and I get borders. I still think this can be improved upon, though. In narrow mode, the shadow is seemingly combined with the border of the top post, which looks bad:

Screenshot from 2023-09-23 16-11-36

I think it would be good to settle for only a shadow :)

from tuba.

bugaevc avatar bugaevc commented on July 2, 2024

even when the style is set to flat (which is not on narrow mode (it's raised))

May I ask, why was that changed? The narrow layout doesn't have a sidebar (which means there's no reason why it has to use the flat style), but I don't think there's a reason why it should use the raised style either?

FWIW, here are the guidelines for which style should be used in which case (clarified as the result of me trying, and failing, to pick the proper style when porting Tuba to Adw.ToolbarView).

from tuba.

GeopJr avatar GeopJr commented on July 2, 2024

I mostly followed the mockup, which unless I misread, shows it as raised on narrow mode

image
(https://gitlab.gnome.org/Teams/Design/other-app-mockups/-/tree/master/tuba)

from tuba.

bugaevc avatar bugaevc commented on July 2, 2024

I don't think that was supposed to imply the raised style. You can in fact imagine the mockup shows the content having been scrolled somewhat, which effectively causes the flat style to turn into raised 🙂

(But perhaps Tobias will correct me)

from tuba.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.