Giter VIP home page Giter VIP logo

Comments (6)

lnicola avatar lnicola commented on August 18, 2024

Does it work with f64? I suspect there's a reason why other libraries use double precision.

from geo.

prideout avatar prideout commented on August 18, 2024

Yes this test passes with f64.

from geo.

michaelkirk avatar michaelkirk commented on August 18, 2024

The issue in #913 is equally possible for any floating point representation, but less probable as precision increases.

I'm not sure if this issue is the same underlying cause as #913.

from geo.

lnicola avatar lnicola commented on August 18, 2024

Right, it can still happen, but it does make sense to use higher than input precision for computation. Not an elegant solution, but worth considering.

from geo.

prideout avatar prideout commented on August 18, 2024

Understood, we'll change our codebase to use f64.

For some context, we're currently using f32 only because we're generating vertex buffer data that gets fed into WebGL, and out of laziness we're avoiding a f64 => f32 conversion step.

from geo.

prideout avatar prideout commented on August 18, 2024

Update: unfortunately we can still easily reproduce a similar panic after changing our codebase to use 64-bit precision.

from geo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.