Make lazy_static optional? about geographiclib-rs HOT 5 CLOSED

It's nice to trim down dependencies, but I'm wondering how many people actually want to use this library without the WGS84 ellipsoid. Do you have this use case? Can you tell me more about it?

lazy_static is a very small, common, and well maintained dependency, so I'd guess that it's unlikely to cause any real damage.

More likely, in my estimation, is that some well meaning person will disable all the default features on their dependencies and then wonder why this library no longer works for them.

from geographiclib-rs.

Do you have this use case? Can you tell me more about it?

I have this exact case where lazy_static seems like suboptimal addition. I'm using geographiclib only in one part of my library, and thus I'm implementing my own Ellipsoid (much leaner) type which implements From/Into Geodesic. So I'm not using the internal geographiclib's wgs84 except for tests.

lazy_static is a very small, common, and well maintained dependency, so I'd guess that it's unlikely to cause any real damage.

That's why I'm not strongly arguing for implementing this change, but rather discussing it as something to consider.

More likely, in my estimation, is that some well meaning person will disable all the default features on their dependencies and then wonder why this library no longer works for them.

Personally, I would assume that mostly experienced Rust users disable default features and expect things to break because of that, and look for the smallest set of necessary features for their use-case.

from geographiclib-rs.

My idea is to add pre-defined ellipsoids (and thus lazy_static) as a default feature. This way no functionality will change for users, but they will be able to use one less dependency when needed.

It is possible just pre-calculate WGS84_GEOD:

static WGS84_GEOD: Geodesic = Geodesic {
   a: WGS84_A
...
};

and add unit test to verify that it equals to Geodesic::new(WGS84_A, WGS84_F)
to catch need of change pre-calculate code if Geodesic::new would modified.

So it would be possible unconditionally remove lazy_statics,
and also make code little faster because of there is no need for read/write atomic in every access.

from geographiclib-rs.