Comments (5)
@GermaVinsmoke i think you need to do some changes in your code to turn easier to test your components. For example you can avoid magic numbers using constants, like in if (len > 7) newVal = newVal.slice(1, len);
instead using those number directly you should use constants in another file and calling them.
It's a good practice to use const
instead of let
when the value that you're using will not change, it is safer guarantee that his value is a constant.
Another point is that you're calculating a lot of bussiness logic inside 'handleChange', it's not wrong, but you could do that in another function for example.
You can open new PR's if you want, or just ignore all these considetations.
from bmi-calculator.
Thanks for helping with this issue. I think it'll also teach me a lot about the testing environment as I am a beginner in this. 😅
from bmi-calculator.
I can help with that
from bmi-calculator.
@GermaVinsmoke can i open a new issue to refactor the folder organization ?
from bmi-calculator.
Yeah
from bmi-calculator.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bmi-calculator.