Issue with file names about discord-downloader-go HOT 8 CLOSED

@macarooni-man Can you give me an example filename it would have, so I can try and replicate it for testing?

It only uses InvalidFilename if it doesn't detect the input as a filename with regex, so it's weird that it's doing that.

from discord-downloader-go.

Yeah for sure, I'll give a more detailed description. So essentially the file type I am using is a preset file for a VST plugin, it just loads the settings of the synth with a list in a text file with the extension ".vital". I modified the source code of the original program to allow it to download the patch from discord and it did the same thing with that one too. Here's what is happening with my modified version of the original;

With your version;

It's interesting because it saves the file in a working state. I wrote a PowerShell script that loops in the output folder to change the file extension while that program is open and the presets work, it's just that the name isn't saved (so jank LOL). But anyway I read through the code and it looks like the issue lies somewhere around line ~1020. I am not new to programming but I have no idea how to use golang syntax haha. Thanks for your help.

from discord-downloader-go.

I believe I have fixed it, I took a peek into the regex file and I found this;
REGEXP_FILENAME = ^^[^/\\:*?"<>|]{1,150}\.[A-Za-z0-9]{2,4}$$

The last part {2,4} I guessed that it was a limit for the file extension in characters and voila I bumped the 4 up to 5 and it works fine. I don't know how many file extensions actually have 5 characters but maybe it's something to consider.

from discord-downloader-go.

@macarooni-man So changing the max to 5 completely fixed your issue?

from discord-downloader-go.

Yeah for sure

from discord-downloader-go.

Glad you figured it out! I changed it to 2,5 for the next release.

from discord-downloader-go.

I just hit the same problem. I would recommend to completely remove the limits for file extensions because file extensions doesn't follow any pattern.
Here is a list of many known file extensions: https://en.wikipedia.org/wiki/List_of_filename_extensions
Here some examples for common file extension:

.c--/.h--
.c++/.h++
.dochtml/.docmhtml/.dothtml
.torrent
.unitypackage
.vbox-extpack

from discord-downloader-go.

I just hit the same problem. I would recommend to completely remove the limits for file extensions because file extensions doesn't follow any pattern.
Here is a list of many known file extensions: https://en.wikipedia.org/wiki/List_of_filename_extensions
Here some examples for common file extension:

.c--/.h--
.c++/.h++
.dochtml/.docmhtml/.dothtml
.torrent
.unitypackage
.vbox-extpack

5559230

from discord-downloader-go.