[Feature] Display profile header for account related pages about lightning-browser-extension HOT 7 CLOSED

I could pick it, if no one is on it.

Should the accounts list page be removed as well, right?

from lightning-browser-extension.

@lujakob thanks. This issue needs to be reviewed first. Also, it would be good for this PR to be merged first

from lightning-browser-extension.

can't we just keep this account header on the new edit pages

we had especially added this feature before.

from lightning-browser-extension.

I also don't think we should remove the functionality to edit other accounts than the currently used one.

+1 for displaying the profile header on subpages of the account. (currently I think only the secret key related things are "below" the account).

from lightning-browser-extension.

@reneaaron is the issue description still accurate? I'm kind of confused with Bumis comment.

from lightning-browser-extension.

I updated the description. I believe we should follow Bumi's comment (add a header to new pages). @lujakob please note for now this is just: import/generate/backup secret key, and nostr settings pages (all added in the mnemonic PR which was just merged)

from lightning-browser-extension.

@lujakob Sorry I didn't clarify that enough. We should try to add the profile header as kind of a Layout for account related subpages so it's clear which account you are currently editing your keys of.

@rolznz Thanks for updating the description.

from lightning-browser-extension.